You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 6fad8f6
Browse filesBrowse the repository at this point in the historyBrowse files
Copy file name to clipboardExpand all lines: docs/adr/ADR-1126-a-dependabot-minor-or-patch-update-of-the-dependency-files-merges-without-a-review.md
+3-3Lines changed: 3 additions & 3 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -23,9 +23,9 @@ Anthropic describes the same problem and its answer in "Solving code review at A
23
23
## Decision
24
24
25
25
1. The resolver computes a tier from the change itself. A pull request is low risk when all of these hold:
26
-
- its author is `dependabot[bot]`, and every commit is authored by `dependabot[bot]`, committed by GitHub (`web-flow`) and carries a verified signature. The author alone is a declared e-mail and `verified` vouches for the committer's key, so a commit a person signs under Dependabot's name is refused;
27
-
- every `update-type` its commit messages declare is `version-update:semver-minor` or `version-update:semver-patch`, and there is at least one;
28
-
- every file it changes is `uv.lock` or `pyproject.toml`.
26
+
- its author is `dependabot[bot]`, it has exactly one commit, and every commit is authored by `dependabot[bot]`, committed by GitHub (`web-flow`) and carries a verified signature. The author alone is a declared e-mail and `verified` vouches for the committer's key, so a commit a person signs under Dependabot's name is refused;
27
+
- every `update-type` its commit messages declare is `version-update:semver-minor` or `version-update:semver-patch`, and every dependency the commit names declares one;
28
+
- every file it changes is `uv.lock` or `pyproject.toml`, a renamed file counting under both of its names.
29
29
2. A low-risk pull request merges without a Claude verdict. Everything else of the merge path is unchanged: the `Pipeline` run of the head succeeded, the branch protection still requires `merge` and `CodeQL`, and a `hold` or `do-not-merge` label or a "do not merge" title still holds it.
30
30
3. Any other pull request keeps ADR-1121. That includes a Dependabot major update, a Dependabot update of a workflow or a Dockerfile, and a Dependabot branch someone else pushed to.
31
31
4. The rule lives in the resolver, which runs from `main` through `workflow_run`: a pull request cannot change its own tier.
Copy file name to clipboardExpand all lines: wiki/adr/cortex/1126-a-dependabot-minor-or-patch-update-of-the-dependency-files-merges-without-a-review.md
+3-3Lines changed: 3 additions & 3 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -21,9 +21,9 @@ Anthropic describes the same problem and its answer in "Solving code review at A
21
21
## Decision
22
22
23
23
1. The resolver computes a tier from the change itself. A pull request is low risk when all of these hold:
24
-
- its author is `dependabot[bot]`, and every commit is authored by `dependabot[bot]`, committed by GitHub (`web-flow`) and carries a verified signature. The author alone is a declared e-mail and `verified` vouches for the committer's key, so a commit a person signs under Dependabot's name is refused;
25
-
- every `update-type` its commit messages declare is `version-update:semver-minor` or `version-update:semver-patch`, and there is at least one;
26
-
- every file it changes is `uv.lock` or `pyproject.toml`.
24
+
- its author is `dependabot[bot]`, it has exactly one commit, and every commit is authored by `dependabot[bot]`, committed by GitHub (`web-flow`) and carries a verified signature. The author alone is a declared e-mail and `verified` vouches for the committer's key, so a commit a person signs under Dependabot's name is refused;
25
+
- every `update-type` its commit messages declare is `version-update:semver-minor` or `version-update:semver-patch`, and every dependency the commit names declares one;
26
+
- every file it changes is `uv.lock` or `pyproject.toml`, a renamed file counting under both of its names.
27
27
2. A low-risk pull request merges without a Claude verdict. Everything else of the merge path is unchanged: the `Pipeline` run of the head succeeded, the branch protection still requires `merge` and `CodeQL`, and a `hold` or `do-not-merge` label or a "do not merge" title still holds it.
28
28
3. Any other pull request keeps ADR-1121. That includes a Dependabot major update, a Dependabot update of a workflow or a Dockerfile, and a Dependabot branch someone else pushed to.
29
29
4. The rule lives in the resolver, which runs from `main` through `workflow_run`: a pull request cannot change its own tier.
0 commit comments