Skip to content

Commit 63c2788

Browse files
committed
fixup! fix(tests): reranker cache-path tests compare paths, not strings (#692)
The core pathlib rule comes from issue #560, not ADR-0244 (review 1 of PR #952). Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_018kyZYuh12mhbtnpuBLP9bi
1 parent b68a26b commit 63c2788

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

‎CHANGELOG.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ adheres to [Semantic Versioning](https://semver.org/).
190190
`\fake\home\.cache\flashrank` to a POSIX literal, and
191191
`test_cell_model_cache_and_state_restore_without_changing_defaults` compared the
192192
`/`-joined path that `core/reranker_model.py` builds (it may not import pathlib,
193-
ADR-0244) to a native `str(Path)`. Both values name the same file.
193+
issue #560) to a native `str(Path)`. Both values name the same file.
194194
- `MCPClient` names the exception when spawning an upstream server fails: the
195195
message is `Failed to spawn: NotImplementedError()` instead of `Failed to spawn: `,
196196
which is what a bare exception with an empty message used to print. The two

‎tests_py/benchmarks/test_reranker_matrix_runtime.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ def test_cell_model_cache_and_state_restore_without_changing_defaults(tmp_path):
140140
):
141141
with selected_cell(cell("l2-2x")):
142142
assert model._MODEL_NAME == ranker._MODEL_NAME == cell("l2-2x").model.name
143-
# core joins with "/" (it may not import pathlib, ADR-0244);
143+
# core joins with "/" (it may not import pathlib, issue #560);
144144
# compare as paths so the native separator does not matter (#692).
145145
assert Path(model._model_path()) == (
146146
tmp_path / model._MODEL_NAME / model._MODEL_FILE

0 commit comments

Comments
 (0)