Repository navigation
Commit 33dc284
fix(hooks): a transcript record's message field can hold anything (#591)
The previous commit guarded the record and left the field below it
unguarded: `(record.get("message") or {}).get("content")` falls back only
when message is falsy, so a truthy non-object (a string, a list) reached
.get() and raised AttributeError in the same unguarded SessionEnd hook
path. Reproduced on the branch with {"type": "assistant", "message":
"not a dict"} before fixing.
_message_content reads the content only when message is an object, and
_tool_names already ignores a content that is not a list of blocks. Four
parametrized cases (string, list, number, bool) cover it; each raises on
the previous code, and the record still counts as a turn.
Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
Claude-Session: https://claude.ai/code/session_01Cz7A6goxVzfKL9NT7k4zDH1 parent 1b0f3dd commit 33dc284
2 files changed
Lines changed: 32 additions & 2 deletions
File tree
- mcp_server/infrastructure
- tests_py/infrastructure
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
29 | 38 | | |
30 | 39 | | |
31 | 40 | | |
| |||
67 | 76 | | |
68 | 77 | | |
69 | 78 | | |
70 | | - | |
71 | | - | |
| 79 | + | |
72 | 80 | | |
73 | 81 | | |
74 | 82 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| 14 | + | |
| 15 | + | |
14 | 16 | | |
15 | 17 | | |
16 | 18 | | |
| |||
120 | 122 | | |
121 | 123 | | |
122 | 124 | | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
0 commit comments