|
| 1 | +"""Canonical text and parse of the backup manifest (issue #731, slice 2).""" |
| 2 | + |
| 3 | +from __future__ import annotations |
| 4 | + |
| 5 | +import json |
| 6 | + |
| 7 | +import pytest |
| 8 | + |
| 9 | +from mcp_server.core import backup_manifest as bm |
| 10 | + |
| 11 | +DIGEST = "a" * 64 |
| 12 | +OTHER = "0123456789abcdef" * 4 |
| 13 | + |
| 14 | + |
| 15 | +def _scan(backend: str, **present) -> dict: |
| 16 | + scanned = {spec.name: None for spec in bm.resources_for(backend)} |
| 17 | + scanned.update(present) |
| 18 | + return scanned |
| 19 | + |
| 20 | + |
| 21 | +def _sqlite_scan(**present) -> dict: |
| 22 | + return _scan( |
| 23 | + "sqlite", sqlite_store=[("methodology/memory.db", DIGEST, 10)], **present |
| 24 | + ) |
| 25 | + |
| 26 | + |
| 27 | +# --- canonical text and parse ---------------------------------------------------- |
| 28 | + |
| 29 | + |
| 30 | +def test_to_json_is_canonical_and_parses_back_unchanged(): |
| 31 | + manifest = bm.build_manifest("sqlite", _sqlite_scan(), "t") |
| 32 | + text = bm.to_json(manifest) |
| 33 | + assert text.endswith("}\n") and not text.endswith("\n\n") |
| 34 | + assert text == json.dumps(manifest, sort_keys=True, indent=2) + "\n" |
| 35 | + assert bm.to_json({"b": "é", "a": 1}) == '{\n "a": 1,\n "b": "\\u00e9"\n}\n' |
| 36 | + assert bm.parse_manifest(text) == manifest |
| 37 | + |
| 38 | + |
| 39 | +def _text(**override) -> str: |
| 40 | + manifest = bm.build_manifest("sqlite", _sqlite_scan(), "t") |
| 41 | + manifest.update(override) |
| 42 | + return json.dumps(manifest) |
| 43 | + |
| 44 | + |
| 45 | +@pytest.mark.parametrize( |
| 46 | + ("text", "message"), |
| 47 | + [ |
| 48 | + ("{", r"^not JSON: "), |
| 49 | + ("[]", r"^not a cortex-backup-manifest document$"), |
| 50 | + ( |
| 51 | + _text(format="cortex-memory-export"), |
| 52 | + r"^not a cortex-backup-manifest document$", |
| 53 | + ), |
| 54 | + (_text(version=2), r"^manifest version 2, this Cortex reads 1$"), |
| 55 | + (_text(version="1"), r"^manifest version '1', this Cortex reads 1$"), |
| 56 | + (_text(backend="auto"), r"^unknown backend 'auto'"), |
| 57 | + (_text(entries={}), r"^entries must be a list of objects$"), |
| 58 | + (_text(entries=["wiki"]), r"^entries must be a list of objects$"), |
| 59 | + ( |
| 60 | + _text(entries=[{"name": "wiki"}]), |
| 61 | + r"^entries \['wiki'\] do not match the sqlite table$", |
| 62 | + ), |
| 63 | + ], |
| 64 | +) |
| 65 | +def test_parse_refuses_another_format_version_or_table(text, message): |
| 66 | + with pytest.raises(bm.ManifestError, match=message): |
| 67 | + bm.parse_manifest(text) |
| 68 | + |
| 69 | + |
| 70 | +def test_parse_refuses_a_manifest_without_entries(): |
| 71 | + manifest = json.loads(_text()) |
| 72 | + del manifest["entries"] |
| 73 | + with pytest.raises(bm.ManifestError, match=r"^entries must be a list of objects$"): |
| 74 | + bm.parse_manifest(json.dumps(manifest)) |
| 75 | + |
| 76 | + |
| 77 | +# --- parse checks every entry against its spec and its files (review of #960) --- |
| 78 | + |
| 79 | + |
| 80 | +def _entry_text(name: str, **override) -> str: |
| 81 | + manifest = bm.build_manifest( |
| 82 | + "sqlite", |
| 83 | + _sqlite_scan(wiki=[("methodology/wiki/a.md", DIGEST, 1)]), |
| 84 | + "t", |
| 85 | + ) |
| 86 | + entry = next(e for e in manifest["entries"] if e["name"] == name) |
| 87 | + entry.update(override) |
| 88 | + return json.dumps(manifest) |
| 89 | + |
| 90 | + |
| 91 | +@pytest.mark.parametrize( |
| 92 | + ("name", "override"), |
| 93 | + [ |
| 94 | + ("sqlite_store", {"path": "/outside/other.db"}), |
| 95 | + ("sqlite_store", {"kind": "dir"}), |
| 96 | + ("sqlite_store", {"secret": True}), |
| 97 | + ("sqlite_store", {"extra": 1}), |
| 98 | + ("wiki", {"present": False}), |
| 99 | + ("backend_marker", {"files": [{"path": "x", "sha256": DIGEST, "size": 1}]}), |
| 100 | + ], |
| 101 | +) |
| 102 | +def test_parse_refuses_an_entry_that_differs_from_its_spec_or_files(name, override): |
| 103 | + with pytest.raises(bm.ManifestError, match=rf"^entry {name} "): |
| 104 | + bm.parse_manifest(_entry_text(name, **override)) |
| 105 | + |
| 106 | + |
| 107 | +def test_parse_refuses_unsorted_files(): |
| 108 | + manifest = bm.build_manifest( |
| 109 | + "sqlite", |
| 110 | + _sqlite_scan( |
| 111 | + wiki=[ |
| 112 | + ("methodology/wiki/a.md", DIGEST, 1), |
| 113 | + ("methodology/wiki/b.md", DIGEST, 1), |
| 114 | + ] |
| 115 | + ), |
| 116 | + "t", |
| 117 | + ) |
| 118 | + manifest["entries"][2]["files"].reverse() |
| 119 | + with pytest.raises( |
| 120 | + bm.ManifestError, match=r"^entry wiki differs from the table or its files$" |
| 121 | + ): |
| 122 | + bm.parse_manifest(json.dumps(manifest)) |
| 123 | + |
| 124 | + |
| 125 | +@pytest.mark.parametrize( |
| 126 | + "override", |
| 127 | + [ |
| 128 | + {"present": "yes"}, |
| 129 | + {"present": None}, |
| 130 | + {"files": {}}, |
| 131 | + {"files": ["methodology/wiki/a.md"]}, |
| 132 | + {"files": [{"path": 1, "sha256": DIGEST, "size": 1}]}, |
| 133 | + {"files": [{"path": "methodology/wiki/a.md", "sha256": 1, "size": 1}]}, |
| 134 | + {"files": [{"path": "methodology/wiki/a.md", "sha256": DIGEST, "size": 1.0}]}, |
| 135 | + {"files": [{"path": "methodology/wiki/a.md", "sha256": DIGEST, "size": True}]}, |
| 136 | + {"files": [{"path": "methodology/wiki/a.md", "sha256": DIGEST}]}, |
| 137 | + ], |
| 138 | +) |
| 139 | +def test_parse_refuses_malformed_presence_or_files(override): |
| 140 | + with pytest.raises( |
| 141 | + bm.ManifestError, match=r"^entry wiki: present or files malformed$" |
| 142 | + ): |
| 143 | + bm.parse_manifest(_entry_text("wiki", **override)) |
| 144 | + |
| 145 | + |
| 146 | +def test_parse_refuses_a_required_entry_marked_absent(): |
| 147 | + text = _entry_text("sqlite_store", present=False, files=[]) |
| 148 | + with pytest.raises( |
| 149 | + bm.ManifestError, match=r"memory\.db is required for a sqlite backup" |
| 150 | + ): |
| 151 | + bm.parse_manifest(text) |
| 152 | + |
| 153 | + |
| 154 | +def test_parse_accepts_absent_and_present_entries_built_by_the_table(): |
| 155 | + text = _entry_text("wiki") |
| 156 | + assert bm.parse_manifest(text) == json.loads(text) |
0 commit comments