fix(terminal): correct compact and unicode widths - #1129

No actionable comments were generated in the recent review. 🎉

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

@coderabbitai please review this stacked follow-up. It contains the compact-date and Unicode-width behavior fixes requested on #1127.

Deploying with    Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

#!/bin/bash
# Get PR details and diff
gh pr view 1129 --repo ryoppippi/ccusage
echo "---DIFF---"
gh pr diff 1129 --repo ryoppippi/ccusage

@ryoppippi Thanks for this follow-up PR! Here's the review.

Review of #1129

rust/crates/ccusage-terminal/src/table.rs — compact date width logic

The refactored first_column_min computation is correct and simpler than the original (eliminates the post-fit_widths_to_terminal .max(10) mutation). One nit: the first and last arms of the expression both return 10, so the whole thing can be collapsed to a single condition:

let first_column_min = if self.compact_dates && total_required <= self.terminal_width {
    12
} else {
    10
};

This makes the intent clearer: "use 12 only when compact_dates is on and the table fits; fall back to 10 otherwise." The snapshot diff confirms the narrower column renders correctly.

rust/crates/ccusage-terminal/src/width.rs — char_display_width via unicode-width

Replacing the blanket else → 2 with a proper Unicode lookup is a solid improvement. A few points:

width_cjk vs width

width_cjk treats ambiguous-width characters as wide (2) in an East Asian context, while width treats them as narrow (1). Ambiguous characters include things like ±, °, and many Greek/Latin extended letters. For most Western terminal users whose terminals are not in CJK mode, width_cjk will over-count these characters by 1 column each, potentially misaligning columns. Using UnicodeWidthChar::width(ch).unwrap_or(1) (falling back to 1 for control chars rather than 0) would be more correct for the general case, while still correctly identifying CJK ideographs as wide.

unwrap_or(0) for control characters

width_cjk returns None for control characters (e.g. \t, \x00). Returning 0 for them is reasonable since visible_width presumably strips/skips ANSI sequences already, but it's worth a test or a comment.

Tests

The new test is a good starting point. Consider adding coverage for the ambiguous-width and None cases:

#[test]
fn char_display_width_cases() {
    // ASCII
    assert_eq!(char_display_width('a'), 1);
    // CJK ideograph
    assert_eq!(char_display_width('表'), 2);
    // Combining mark (width 0 — does not advance cursor)
    assert_eq!(char_display_width('\u{0301}'), 0);
    // Control character → unwrap_or(0)
    assert_eq!(char_display_width('\x07'), 0);
}

Dependency

unicode-width 0.2.2 is the current latest release — good choice. The semver spec "0.2.2" in Cargo.toml allows compatible patch bumps, which is fine.

Summary

The main actionable item is the width_cjk / width question — worth a deliberate choice with a comment explaining why, either way.

@coderabbitai review

@coderabbitai pushed 0e8eacc to address the standard Unicode width review note: it now uses UnicodeWidthChar::width, keeps controls at zero width, covers ambiguous-width characters in tests, and simplifies the compact-date width condition. Please review again.

#!/bin/bash
# Get the latest diff for commit 0e8eacc
gh pr diff 1129 --repo ryoppippi/ccusage
echo "---COMMIT---"
gh api repos/ryoppippi/ccusage/commits/0e8eacc

@ryoppippi Everything looks great — all three items from the previous review have been addressed cleanly in commit 0e8eacc:

The char_display_width implementation is now a clean one-liner, and the test suite explicitly pins the ambiguous-width case to 1, which makes the design intent self-documenting. The snapshot update also correctly reflects the narrower compact date wrapping. No further changes needed.

[approve]

@coderabbitai rebased this follow-up onto main after #1127 was merged, preserving only the compact-date and Unicode-width fixes in this PR. Please review the updated diff again.

@coderabbitai review

#!/bin/bash
gh pr diff 1129 --repo ryoppippi/ccusage
echo "---PR VIEW---"
gh pr view 1129 --repo ryoppippi/ccusage
echo "---COMMITS---"
gh api repos/ryoppippi/ccusage/pulls/1129/commits | jq '[.[] | {sha: .sha, message: .commit.message}]'

@ryoppippi The rebase onto main looks clean — all the fixes from commit 26f3a6f are preserved intact with no regressions introduced:

The only diff artifact from the rebase is the assertion_line bump from 494 → 495 in the snapshot, which is harmless. Everything else is identical to what was approved previously. Good to go!

[approve]

ccusage performance comparison

PR SHA: 588ee58ccbdf
Base SHA: d8c775e2cec8

This compares the PR package against the configured base package on the same CI runner.

Package runner startup

Execution setup measures any pre-benchmark package materialization used by the execution benchmark. Bunx temp cache measures one bunx -p <url> ccusage --version run with an empty Bun install cache. Warm reuses that cache and reports the median of repeated runs.

Cached bunx execution performance

Runs the same large fixture through bunx -p <pkg.pr.new URL> ccusage after the Bun install cache has already been populated by the startup measurement. This separates cached package-runner execution from first-fetch package materialization.

Fixtures: Claude /home/runner/work/_temp/ccusage-large-fixture (1.01 GiB, 2,597 files), Codex /home/runner/work/_temp/ccusage-large-codex-fixture (1.01 GiB, 2,597 files)
Base package: d8c775e2cec8; PR package: 588ee58ccbdf. Both run through bunx -p <pkg.pr.new URL> ccusage using the warmed Bun install cache from package runner startup, measured by hyperfine with 0 warmups and 1 runs.

Package runtime diagnostics

Compares the PR package wrapper, the installed native optional dependency binary, and the workspace release binary on the same large fixture. This identifies whether slow package results come from JavaScript wrapper overhead, the published native binary build, or the Rust core itself.

Fixtures: Claude /home/runner/work/_temp/ccusage-large-fixture (1.01 GiB, 2,597 files), Codex /home/runner/work/_temp/ccusage-large-codex-fixture (1.01 GiB, 2,597 files)
All rows run --offline --json, measured by hyperfine with 0 warmups and 1 runs. This isolates wrapper overhead from the installed native optional dependency and the workspace release binary built on the runner.

Committed fixture performance

Committed small fixtures for stable PR-to-PR feedback and explicit Claude/Codex command coverage.

Fixtures: Claude apps/ccusage/test/fixtures/claude (0.00 MiB, 2 files), Codex apps/ccusage/test/fixtures/codex (0.00 MiB, 1 files)
Base runs the published ccusage package from pkg.pr.new, installed before measurement; PR runs the published ccusage package from pkg.pr.new, installed before measurement. Both run --offline --json, measured by hyperfine with 2 warmups and 7 runs.

Large real-world-shaped fixture performance

Generated fixtures shaped from aggregate local log statistics: thousands of JSONL files, many small sessions, and a long tail of larger sessions. No real prompts, paths, or outputs are stored in the fixtures.

Fixtures: Claude /home/runner/work/_temp/ccusage-large-fixture (1.01 GiB, 2,597 files), Codex /home/runner/work/_temp/ccusage-large-codex-fixture (1.01 GiB, 2,597 files)
Base runs the published ccusage package from pkg.pr.new, installed before measurement; PR runs the published ccusage package from pkg.pr.new, installed before measurement. Both run --offline --json, measured by hyperfine with 0 warmups and 1 runs.

Artifact size

Lower medians and smaller artifacts are better. CI runner noise still applies; use same-run ratios as directional PR feedback, not release guarantees.

ccusage performance comparison

PR SHA: 588ee58ccbdf
Base SHA: d8c775e2cec8

This compares the Rust PR release binary against the configured base package on the same CI runner.

Package runner startup

Execution setup measures any pre-benchmark package materialization used by the execution benchmark. Bunx temp cache measures one bunx -p <url> ccusage --version run with an empty Bun install cache. Warm reuses that cache and reports the median of repeated runs.

Cached bunx execution performance

Runs the same large fixture through bunx -p <pkg.pr.new URL> ccusage after the Bun install cache has already been populated by the startup measurement. This separates cached package-runner execution from first-fetch package materialization.

Fixtures: Claude /home/runner/work/_temp/ccusage-large-fixture (1.01 GiB, 2,597 files), Codex /home/runner/work/_temp/ccusage-large-codex-fixture (1.01 GiB, 2,597 files)
Base package: d8c775e2cec8; PR package: 588ee58ccbdf. Both run through bunx -p <pkg.pr.new URL> ccusage using the warmed Bun install cache from package runner startup, measured by hyperfine with 0 warmups and 1 runs.

Package runtime diagnostics

Compares the PR package wrapper, the installed native optional dependency binary, and the workspace release binary on the same large fixture. This identifies whether slow package results come from JavaScript wrapper overhead, the published native binary build, or the Rust core itself.

Fixtures: Claude /home/runner/work/_temp/ccusage-large-fixture (1.01 GiB, 2,597 files), Codex /home/runner/work/_temp/ccusage-large-codex-fixture (1.01 GiB, 2,597 files)
All rows run --offline --json, measured by hyperfine with 0 warmups and 1 runs. This isolates wrapper overhead from the installed native optional dependency and the workspace release binary built on the runner.

Committed fixture performance

Committed small fixtures for stable PR-to-PR feedback and explicit Claude/Codex command coverage.

Fixtures: Claude apps/ccusage/test/fixtures/claude (0.00 MiB, 2 files), Codex apps/ccusage/test/fixtures/codex (0.00 MiB, 1 files)
Base runs the published ccusage package from pkg.pr.new, installed before measurement; PR runs rust/target/release/ccusage directly. Both run --offline --json, measured by hyperfine with 2 warmups and 7 runs.

Large real-world-shaped fixture performance

Generated fixtures shaped from aggregate local log statistics: thousands of JSONL files, many small sessions, and a long tail of larger sessions. No real prompts, paths, or outputs are stored in the fixtures.

Fixtures: Claude /home/runner/work/_temp/ccusage-large-fixture (1.01 GiB, 2,597 files), Codex /home/runner/work/_temp/ccusage-large-codex-fixture (1.01 GiB, 2,597 files)
Base runs the published ccusage package from pkg.pr.new, installed before measurement; PR runs rust/target/release/ccusage directly. Both run --offline --json, measured by hyperfine with 0 warmups and 1 runs.

Artifact size

Lower medians and smaller artifacts are better. CI runner noise still applies; use same-run ratios as directional PR feedback, not release guarantees.

ccusage performance comparison

PR SHA: 0e8eacc41336
Base SHA: d8c775e2cec8

This compares the Rust PR release binary against the configured base package on the same CI runner.

Package runner startup

Execution setup measures any pre-benchmark package materialization used by the execution benchmark. Bunx temp cache measures one bunx -p <url> ccusage --version run with an empty Bun install cache. Warm reuses that cache and reports the median of repeated runs.

Cached bunx execution performance

Runs the same large fixture through bunx -p <pkg.pr.new URL> ccusage after the Bun install cache has already been populated by the startup measurement. This separates cached package-runner execution from first-fetch package materialization.

Fixtures: Claude /home/runner/work/_temp/ccusage-large-fixture (1.01 GiB, 2,597 files), Codex /home/runner/work/_temp/ccusage-large-codex-fixture (1.01 GiB, 2,597 files)
Base package: d8c775e2cec8; PR package: 0e8eacc41336. Both run through bunx -p <pkg.pr.new URL> ccusage using the warmed Bun install cache from package runner startup, measured by hyperfine with 0 warmups and 1 runs.

Package runtime diagnostics

Compares the PR package wrapper, the installed native optional dependency binary, and the workspace release binary on the same large fixture. This identifies whether slow package results come from JavaScript wrapper overhead, the published native binary build, or the Rust core itself.

Fixtures: Claude /home/runner/work/_temp/ccusage-large-fixture (1.01 GiB, 2,597 files), Codex /home/runner/work/_temp/ccusage-large-codex-fixture (1.01 GiB, 2,597 files)
All rows run --offline --json, measured by hyperfine with 0 warmups and 1 runs. This isolates wrapper overhead from the installed native optional dependency and the workspace release binary built on the runner.

Committed fixture performance

Committed small fixtures for stable PR-to-PR feedback and explicit Claude/Codex command coverage.

Fixtures: Claude apps/ccusage/test/fixtures/claude (0.00 MiB, 2 files), Codex apps/ccusage/test/fixtures/codex (0.00 MiB, 1 files)
Base runs the published ccusage package from pkg.pr.new, installed before measurement; PR runs rust/target/release/ccusage directly. Both run --offline --json, measured by hyperfine with 2 warmups and 7 runs.

Large real-world-shaped fixture performance

Generated fixtures shaped from aggregate local log statistics: thousands of JSONL files, many small sessions, and a long tail of larger sessions. No real prompts, paths, or outputs are stored in the fixtures.

Fixtures: Claude /home/runner/work/_temp/ccusage-large-fixture (1.01 GiB, 2,597 files), Codex /home/runner/work/_temp/ccusage-large-codex-fixture (1.01 GiB, 2,597 files)
Base runs the published ccusage package from pkg.pr.new, installed before measurement; PR runs rust/target/release/ccusage directly. Both run --offline --json, measured by hyperfine with 0 warmups and 1 runs.

Artifact size

Lower medians and smaller artifacts are better. CI runner noise still applies; use same-run ratios as directional PR feedback, not release guarantees.

ccusage performance comparison

PR SHA: 0e8eacc41336
Base SHA: d8c775e2cec8

This compares the PR package against the configured base package on the same CI runner.

Package runner startup

Execution setup measures any pre-benchmark package materialization used by the execution benchmark. Bunx temp cache measures one bunx -p <url> ccusage --version run with an empty Bun install cache. Warm reuses that cache and reports the median of repeated runs.

Cached bunx execution performance

Runs the same large fixture through bunx -p <pkg.pr.new URL> ccusage after the Bun install cache has already been populated by the startup measurement. This separates cached package-runner execution from first-fetch package materialization.

Fixtures: Claude /home/runner/work/_temp/ccusage-large-fixture (1.01 GiB, 2,597 files), Codex /home/runner/work/_temp/ccusage-large-codex-fixture (1.01 GiB, 2,597 files)
Base package: d8c775e2cec8; PR package: 0e8eacc41336. Both run through bunx -p <pkg.pr.new URL> ccusage using the warmed Bun install cache from package runner startup, measured by hyperfine with 0 warmups and 1 runs.

Package runtime diagnostics

Compares the PR package wrapper, the installed native optional dependency binary, and the workspace release binary on the same large fixture. This identifies whether slow package results come from JavaScript wrapper overhead, the published native binary build, or the Rust core itself.

Fixtures: Claude /home/runner/work/_temp/ccusage-large-fixture (1.01 GiB, 2,597 files), Codex /home/runner/work/_temp/ccusage-large-codex-fixture (1.01 GiB, 2,597 files)
All rows run --offline --json, measured by hyperfine with 0 warmups and 1 runs. This isolates wrapper overhead from the installed native optional dependency and the workspace release binary built on the runner.

Committed fixture performance

Committed small fixtures for stable PR-to-PR feedback and explicit Claude/Codex command coverage.

Fixtures: Claude apps/ccusage/test/fixtures/claude (0.00 MiB, 2 files), Codex apps/ccusage/test/fixtures/codex (0.00 MiB, 1 files)
Base runs the published ccusage package from pkg.pr.new, installed before measurement; PR runs the published ccusage package from pkg.pr.new, installed before measurement. Both run --offline --json, measured by hyperfine with 2 warmups and 7 runs.

Large real-world-shaped fixture performance

Generated fixtures shaped from aggregate local log statistics: thousands of JSONL files, many small sessions, and a long tail of larger sessions. No real prompts, paths, or outputs are stored in the fixtures.

Fixtures: Claude /home/runner/work/_temp/ccusage-large-fixture (1.01 GiB, 2,597 files), Codex /home/runner/work/_temp/ccusage-large-codex-fixture (1.01 GiB, 2,597 files)
Base runs the published ccusage package from pkg.pr.new, installed before measurement; PR runs the published ccusage package from pkg.pr.new, installed before measurement. Both run --offline --json, measured by hyperfine with 0 warmups and 1 runs.

Artifact size

Lower medians and smaller artifacts are better. CI runner noise still applies; use same-run ratios as directional PR feedback, not release guarantees.