Skip to content

Repository navigation

Commit dd2a2cc

Browse files
ryoppippiryoppippi
committed
ci: mount test's Nix sticky disk in the perf comment legs
ccusage-perf-comment only runs on pull requests, and pull requests never commit a sticky disk, so its own per-leg keys would stay freshly formatted on every run. Mount the disk test commits on every push to main instead: it installs `just` and resolves the same flake inputs. Both legs mount it read-only, so the per-runtime cache-scope that kept their saves apart is no longer needed. Reported by pullfrog in review.
1 parent 868991e commit dd2a2cc

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

‎.github/workflows/ci.yaml‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -469,8 +469,10 @@ jobs:
469469
- name: Setup Nix
470470
uses: ./.github/actions/setup-nix-cache
471471
with:
472-
# js and rust legs share this job id, so scope the cache per runtime.
473-
cache-scope: ${{ matrix.runtime }}
472+
# This job only runs on pull requests, which never commit a sticky
473+
# disk, so both legs read test's instead: it installs `just` and the
474+
# same flake inputs on every push to main.
475+
disk-job: test
474476
# This job only benchmarks the prebuilt ccusage binary bundled in the
475477
# installed pkg.pr.new package (no Rust build happens here), so the full
476478
# `nix develop` dev shell is unnecessary. Install just the tools the perf

0 commit comments

Comments
 (0)