Skip to content

Commit ace4c86

Browse files
committed
ci: rename lint-check to check and warm the dev shell before tests
Two CI tweaks: - Rename the `lint-check` job to `check` (and its action-timeline `needs` reference). `nix flake check` covers far more than linting — clippy, treefmt, schema drift, gitleaks, build — so `check` describes it better. - Add a `nix develop --command true` warm-up step to the `test` job so the dev shell realization and its pnpm install hook land in a dedicated step instead of bleeding into the first timed step and adding noise to action-timeline.
1 parent 388496f commit ace4c86

1 file changed

Lines changed: 7 additions & 2 deletions

File tree

‎.github/workflows/ci.yaml‎

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
- id: detect
2121
uses: ./.github/actions/detect-code-changes
2222

23-
lint-check:
23+
check:
2424
needs: changes
2525
if: needs.changes.outputs.code-changed == 'true'
2626
runs-on: blacksmith-32vcpu-ubuntu-2404-arm
@@ -47,6 +47,11 @@ jobs:
4747
ref: ${{ github.event.pull_request.head.sha || github.sha }}
4848
persist-credentials: false
4949
- uses: ./.github/actions/setup-nix
50+
# Realize the dev shell (and run its pnpm install hook) up front so the
51+
# setup time lands in this dedicated step instead of bleeding into the
52+
# first timed step below and adding noise to action-timeline.
53+
- name: Warm Nix dev shell
54+
run: nix develop --command true
5055
- name: Create default Claude directories for tests
5156
run: |
5257
mkdir -p "$HOME/.claude/projects"
@@ -364,7 +369,7 @@ jobs:
364369
action-timeline:
365370
needs:
366371
- changes
367-
- lint-check
372+
- check
368373
- test
369374
- build-native-packages
370375
- npm-publish-dry-run-and-upload-pkg-pr-now

0 commit comments

Comments
 (0)