Skip to content

Repository navigation

Commit 9786ab1

Browse files
ryoppippiryoppippi
authored
ci: drop redundant schema-check job (#1229)
The `schema-check` job regenerated `config-schema.json` via `pnpm run generate:schema` and diffed it against the committed files. `nix flake check` (run by `lint-check`) already covers this: its `treefmt` check runs the `schema-gen` formatter under `--fail-on-change`, using the same `generate-config-schema` binary, the same `oxfmt` pass, and the same copy to `docs/public/config-schema.json`. Verified that a stale schema fails `nix build .#checks.<system>.treefmt`. Removing the standalone job drops one full `setup-nix` + schema-gen run from CI. The `schema-check` entry must also be removed from the `main` ruleset's required status checks, otherwise PRs would block waiting for a check that no longer runs.
1 parent 1163690 commit 9786ab1

1 file changed

Lines changed: 0 additions & 26 deletions

File tree

‎.github/workflows/ci.yaml‎

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -371,31 +371,6 @@ jobs:
371371
PR_NUMBER: ${{ github.event.pull_request.number }}
372372
run: nix develop --command pnpm exec bun .github/scripts/upsert-pr-comment.ts
373373

374-
schema-check:
375-
needs: changes
376-
if: needs.changes.outputs.code-changed == 'true'
377-
runs-on: ubuntu-24.04-arm
378-
steps:
379-
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
380-
- uses: ./.github/actions/setup-nix
381-
- name: Generate schema files
382-
run: nix develop --command pnpm run generate:schema
383-
working-directory: apps/ccusage
384-
- name: Check if schema files are up-to-date
385-
run: |
386-
if git diff --exit-code apps/ccusage/config-schema.json docs/public/config-schema.json; then
387-
echo "✅ Schema files are up-to-date"
388-
else
389-
echo "❌ Schema files are not up-to-date. Please run 'pnpm run generate:schema' and commit the changes."
390-
echo ""
391-
echo "Changed files:"
392-
git diff --name-only apps/ccusage/config-schema.json docs/public/config-schema.json
393-
echo ""
394-
echo "Diff:"
395-
git diff apps/ccusage/config-schema.json docs/public/config-schema.json
396-
exit 1
397-
fi
398-
399374
action-timeline:
400375
needs:
401376
- changes
@@ -406,7 +381,6 @@ jobs:
406381
- ccusage-preview-e2e
407382
- ccusage-perf-comment
408383
- ccusage-rust-perf-comment
409-
- schema-check
410384
if: ${{ always() }}
411385
runs-on: ubuntu-slim
412386
steps:

0 commit comments

Comments
 (0)