You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 8ff5cb8
Browse filesBrowse the repository at this point in the historyBrowse files
ci: isolate tirith SARIF upload in a least-privilege job
Address CodeRabbit's security review: keep the elevated
`security-events: write` scope out of any job that executes PR-controlled
code.
- `tirith-scan` now holds only `contents: read`. It still runs the local
action, the PR flake and the installed tirith (it must, to scan the PR),
but with no write scope a neutered scan cannot abuse any privilege —
the same trust model as the existing `test`/`build` jobs that run the
PR's `nix flake check`.
- The SARIF is handed off as an artifact and published by a new
`tirith-sarif-upload` job that never executes PR code: it only checks
out files for path mapping and runs trusted, pinned actions
(download-artifact + codeql upload-sarif). This is the only job with
`security-events: write`.
- The upload runs `always()` so findings reach the Security tab even when
the gate blocks the PR, and is skipped for fork PRs (read-only token
cannot upload).
0 commit comments