Skip to content

Commit 8d132f3

Browse files
committed
ci: fold nix flake check into the test job
The standalone `check` job duplicated the `test` job's checkout and Nix cache restore on a second runner just to run `nix flake check`. Move the check into the `test` job as an early background step so it overlaps the JS toolchain install and the test runs, and drop the separate job (and its `action-timeline` dependency). Note: this removes the `check` status check; `test` now covers it. Branch protection required-checks may need updating. Uses the GitHub Actions parallel-steps feature: https://github.blog/changelog/2026-06-25-actions-steps-can-now-be-run-in-parallel/
1 parent d065a10 commit 8d132f3

1 file changed

Lines changed: 7 additions & 11 deletions

File tree

‎.github/workflows/ci.yaml‎

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -21,16 +21,6 @@ jobs:
2121
- id: detect
2222
uses: ./.github/actions/detect-code-changes
2323

24-
check:
25-
needs: changes
26-
if: needs.changes.outputs.code-changed == 'true'
27-
runs-on: blacksmith-32vcpu-ubuntu-2404
28-
29-
steps:
30-
- uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3
31-
- uses: ./.github/actions/setup-nix-cache
32-
- run: nix flake check --print-build-logs
33-
3424
test:
3525
needs: changes
3626
if: needs.changes.outputs.code-changed == 'true'
@@ -46,6 +36,13 @@ jobs:
4636
ref: ${{ github.event.pull_request.head.sha || github.sha }}
4737
persist-credentials: false
4838
- uses: ./.github/actions/setup-nix-cache
39+
# `nix flake check` only needs the checkout and Nix, so kick it off in the
40+
# background right away. It then overlaps the JS toolchain install and the
41+
# test runs below instead of occupying a separate runner with its own
42+
# checkout and Nix cache restore.
43+
- name: Run nix flake check
44+
background: true
45+
run: nix flake check --print-build-logs
4946
# Node tests need the JS toolchain; the Rust tests run via `nix build`. Install
5047
# just pnpm/node/just instead of realizing the full dev shell, which drags
5148
# in every linter, formatter, and the pre-commit hook closure and dominated
@@ -416,7 +413,6 @@ jobs:
416413
action-timeline:
417414
needs:
418415
- changes
419-
- check
420416
- test
421417
- build-native-packages
422418
- npm-publish-dry-run-and-upload-pkg-pr-now

0 commit comments

Comments
 (0)