Repository navigation
Commit 7ee95ee
committed
fix(opencode): keep the pushed-down window a day wider than the report's
A cubic review pointed out that the push-down filters on
`message.time_created` while the report filters on the payload's
`time.created`, and the scale check only proves those share a unit, not a
value. A column drifting from its payload by a few hours would therefore
exclude a row near a window edge — silently, since SQL never hands it to
the payload check.
Widen only the pushed-down bounds by a day on each side. The exact window
still runs per row against the payload, so the margin costs a few extra
rows to scan and cannot change which entries survive. The new test fails
without it.
The remaining exposure is a column drifting by more than a day, or a
column with mixed scales that the sampled rows do not reveal. Both would
need a full-column scan to detect, which is the cost this push-down
exists to avoid; the local install shows a maximum delta of 0 across 600
rows.1 parent d72e237 commit 7ee95ee
1 file changed
Lines changed: 46 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
205 | 205 | | |
206 | 206 | | |
207 | 207 | | |
208 | | - | |
| 208 | + | |
209 | 209 | | |
210 | 210 | | |
211 | 211 | | |
| |||
367 | 367 | | |
368 | 368 | | |
369 | 369 | | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
| 378 | + | |
| 379 | + | |
| 380 | + | |
| 381 | + | |
| 382 | + | |
| 383 | + | |
| 384 | + | |
370 | 385 | | |
371 | 386 | | |
372 | 387 | | |
| |||
1031 | 1046 | | |
1032 | 1047 | | |
1033 | 1048 | | |
| 1049 | + | |
| 1050 | + | |
| 1051 | + | |
| 1052 | + | |
| 1053 | + | |
| 1054 | + | |
| 1055 | + | |
| 1056 | + | |
| 1057 | + | |
| 1058 | + | |
| 1059 | + | |
| 1060 | + | |
| 1061 | + | |
| 1062 | + | |
| 1063 | + | |
| 1064 | + | |
| 1065 | + | |
| 1066 | + | |
| 1067 | + | |
| 1068 | + | |
| 1069 | + | |
| 1070 | + | |
| 1071 | + | |
| 1072 | + | |
| 1073 | + | |
| 1074 | + | |
| 1075 | + | |
| 1076 | + | |
| 1077 | + | |
| 1078 | + | |
1034 | 1079 | | |
1035 | 1080 | | |
1036 | 1081 | | |
| |||
0 commit comments