Skip to content

Commit 745b3e6

Browse files
committed
test(adapter): cover the session window edge cases from review
Document `filter_session_summaries_by_last_activity` in the crate README, add `--since`-only and missing/unparseable `lastActivity` cases for the helper, and restore a fixture-backed Qwen session test that checks the `--until` day boundary in the report timezone through the JSON report.
1 parent 376faf3 commit 745b3e6

3 files changed

Lines changed: 70 additions & 0 deletions

File tree

‎rust/adapters/common/README.md‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@ layers.
1313
so output does not depend on worker scheduling, and `--single-thread` collapses
1414
to a plain sequential read.
1515
- `filter_loaded_entries_by_date` — the shared `--since`/`--until` filter.
16+
- `filter_session_summaries_by_last_activity` — the same window applied to
17+
session summaries by the local day of their last activity.
1618
- `jsonl` — the streaming JSONL parsing helpers.
1719
- `report::print_table_for_agent` — the usage table for adapters whose rows are
1820
plain `UsageSummary` values, parameterized by agent name.
@@ -24,6 +26,7 @@ layers.
2426
- `collect_files_with_extension`
2527
- `collect_files_matching`
2628
- `filter_loaded_entries_by_date`
29+
- `filter_session_summaries_by_last_activity`
2730
- `chunk_file_indexes_by_size`
2831
- `read_files_parallel`
2932

‎rust/adapters/common/src/lib.rs‎

Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -252,6 +252,43 @@ mod tests {
252252
);
253253
}
254254

255+
#[test]
256+
fn session_window_with_only_since_keeps_everything_from_that_day() {
257+
let shared = SharedArgs {
258+
since: Some("20260223".to_string()),
259+
timezone: Some("UTC".to_string()),
260+
..SharedArgs::default()
261+
};
262+
263+
assert_eq!(
264+
filtered_session_ids(&shared),
265+
["start-of-day", "end-of-day", "after"]
266+
);
267+
}
268+
269+
#[test]
270+
fn session_window_drops_rows_without_a_parseable_last_activity() {
271+
let missing = UsageSummary {
272+
last_activity: None,
273+
..session_summary("missing", "")
274+
};
275+
let unparsable = session_summary("unparsable", "2026-02-23");
276+
for shared in [
277+
SharedArgs {
278+
since: Some("20260101".to_string()),
279+
..SharedArgs::default()
280+
},
281+
SharedArgs {
282+
until: Some("20991231".to_string()),
283+
..SharedArgs::default()
284+
},
285+
] {
286+
let mut rows = vec![missing.clone(), unparsable.clone()];
287+
filter_session_summaries_by_last_activity(&mut rows, &shared);
288+
assert!(rows.is_empty(), "{:?}/{:?}", shared.since, shared.until);
289+
}
290+
}
291+
255292
#[test]
256293
fn collects_nested_files_accepted_by_the_predicate() {
257294
let fixture = Fixture::new();

‎rust/adapters/qwen/src/lib.rs‎

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,36 @@ mod tests {
9292
assert_eq!(entries[0].extra_total_tokens, 10);
9393
}
9494

95+
#[test]
96+
fn qwen_session_report_keeps_sessions_last_active_on_the_until_day() {
97+
let fixture = fs_fixture!({
98+
// 2026-02-24T02:00Z is still 2026-02-23 in America/Los_Angeles (UTC-8).
99+
"projects/myProject/chats/until-day.jsonl": r#"{"type":"assistant","model":"qwen3-coder-plus","timestamp":"2026-02-24T02:00:00.000Z","sessionId":"until-day","usageMetadata":{"promptTokenCount":100,"candidatesTokenCount":50}}"#,
100+
"projects/myProject/chats/after-day.jsonl": r#"{"type":"assistant","model":"qwen3-coder-plus","timestamp":"2026-02-24T18:00:00.000Z","sessionId":"after-day","usageMetadata":{"promptTokenCount":10,"candidatesTokenCount":5}}"#,
101+
});
102+
103+
let shared = SharedArgs {
104+
mode: CostMode::Display,
105+
timezone: Some("America/Los_Angeles".to_string()),
106+
since: Some("20260223".to_string()),
107+
until: Some("20260223".to_string()),
108+
..SharedArgs::default()
109+
};
110+
let _guard = EnvVarGuard::set("QWEN_DATA_DIR", fixture.root());
111+
let entries = load_entries(&shared).unwrap();
112+
let mut rows = summarize_entries(&entries, AgentReportKind::Session).unwrap();
113+
filter_session_summaries_by_last_activity(&mut rows, &shared);
114+
let report = report_from_rows(&rows, AgentReportKind::Session);
115+
116+
assert_eq!(report["sessions"].as_array().map(Vec::len), Some(1));
117+
assert_eq!(report["sessions"][0]["sessionId"], "until-day");
118+
assert_eq!(
119+
report["sessions"][0]["lastActivity"],
120+
"2026-02-24T02:00:00.000Z"
121+
);
122+
assert_eq!(report["totals"]["totalTokens"], 150);
123+
}
124+
95125
#[test]
96126
fn builds_qwen_daily_json_report_with_reasoning_in_total() {
97127
let fixture = fs_fixture!({

0 commit comments

Comments
 (0)