Skip to content

Commit 0a3391e

Browse files
committed
perf(ci): drop the full dev shell from the test job
The test job spent ~73s on "Warm Nix dev shell" realizing the complete development shell — every linter, formatter, renovate, and the pre-commit hook closure — even though pnpm install itself was only ~7s. Now that coverage is a `nix build` derivation, Vitest is the sole step that needs a JS toolchain. Replace `nix develop` with `nix profile install pnpm_11 bun just`, mirroring the perf-comment and pkg-pr-new jobs, then run `just test-vitest` directly. This skips the heavy shell closure while keeping the exact tools Vitest needs.
1 parent 7a38566 commit 0a3391e

1 file changed

Lines changed: 8 additions & 6 deletions

File tree

‎.github/workflows/ci.yaml‎

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -48,17 +48,19 @@ jobs:
4848
ref: ${{ github.event.pull_request.head.sha || github.sha }}
4949
persist-credentials: false
5050
- uses: ./.github/actions/setup-nix
51-
# Realize the dev shell (and run its pnpm install hook) up front so the
52-
# setup time lands in this dedicated step instead of bleeding into the
53-
# first timed step below and adding noise to action-timeline.
54-
- name: Warm Nix dev shell
55-
run: nix develop --command true
51+
# Vitest is the only step that needs the JS toolchain (the coverage step
52+
# builds via `nix build`), so install just pnpm/bun/just instead of
53+
# realizing the full dev shell, which drags in every linter, formatter,
54+
# and the pre-commit hook closure and dominated this job's wall time.
55+
- name: Install JS tooling
56+
run: nix profile install --inputs-from . nixpkgs#pnpm_11 nixpkgs#bun nixpkgs#just
57+
- run: pnpm install --frozen-lockfile
5658
- name: Create default Claude directories for tests
5759
run: |
5860
mkdir -p "$HOME/.claude/projects"
5961
mkdir -p "$HOME/.config/claude/projects"
6062
- name: Run Vitest tests
61-
run: nix develop --command just test-vitest
63+
run: just test-vitest
6264
- name: Generate Rust coverage report
6365
run: |
6466
mkdir -p coverage

0 commit comments

Comments
 (0)