Makefile: add golangci-lint version check:#71
Merged
hao022 merged 1 commit intoccfos:mainfrom Nov 25, 2025
Merged
Conversation
hao022
reviewed
Nov 24, 2025
Makefile
Outdated
| -X main.AppVersion=$(APP_VERSION) \ | ||
| -X main.AppGitCommit=$(APP_COMMIT) \ | ||
| -X main.AppBuildTime=$(APP_BUILD_TIME)" | ||
| GO_VERSION := $(shell go version | awk '{print $$3}') |
Member
There was a problem hiding this comment.
why not use the below cmd
go env GOVERSION
Contributor
Author
|
已收到
|
huhong-web
commented
Nov 24, 2025
Makefile
Outdated
|
|
||
| which golangci-lint >/dev/null || \ | ||
| { echo "golangci-lint not found: $(GO) install github.com/golangci/golangci-lint/cmd/golangci-lint@latest"; exit 1; } | ||
| @lint_go_version=$$(golangci-lint version --format json | cut -d'"' -f4); \ |
Contributor
Author
There was a problem hiding this comment.
jq need extra installation, so use cut.
Makefile
Outdated
| which golangci-lint >/dev/null || \ | ||
| { echo "golangci-lint not found: $(GO) install github.com/golangci/golangci-lint/cmd/golangci-lint@latest"; exit 1; } | ||
| @lint_go_version=$$(golangci-lint version --format json | cut -d'"' -f4); \ | ||
| older=$$(printf "%s\n%s" "$$lint_go_version" "$(GO_VERSION)" | sort -V | head -1); \ |
Contributor
Author
There was a problem hiding this comment.
In some case, e.g, comparing 1.11 and 1.9, need to do extra process.
…ersion used to
build golangci-lint matches the Go version of the current project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the golangci-lint you are using was built with a Go version lower than the current project's code, golangci-lint will be stuck and use huge memory.