fix: correct softirq_latency metric behavior#130
Merged
hao022 merged 1 commit intoccfos:mainfrom Jan 30, 2026
Merged
Conversation
Contributor
|
看起来没问题,请更新一版,把commit message 用英文写一下吧。 |
Contributor
Author
ok,已修改 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: correct softirq_latency metric behavior
softirq_raise can be triggered by hard interrupts and is re-entrant.
The previous implementation updated the timestamp on every raise, causing the reported value to reflect the minimum latency, which is misleading and of limited usefulness.
This change introduces a per-softirq guard flag. The timestamp is recorded only on the first softirq_raise and remains unchanged until the corresponding softirq handler runs. This allows the metric to accurately reflect the maximum latency between the initial hard interrupt and the subsequent softirq execution.
go test:

functional test:

Enabled the TIMER softirq metric and extended the latency range for validation.
A custom kernel module was used to block softirq processing for 50 ms, and the collected TIMER latency met expectations.
fix: correct softirq_latency metric behavior
softirq_raise can be triggered by hard interrupts and is re-entrant.
The previous implementation updated the timestamp on every raise, causing the reported value to reflect the minimum latency, which is misleading and of limited usefulness.
Signed-off-by: lizhong [email protected]