Repository navigation
Commit ae308f5
committed
iOS: Remove the software renderer fallback
iOS is Impeller-only and requires iOS 15, so there is no software
renderer. The `IOSRenderingAPI::kSoftware` path doesn't actually render
in software: on a simulator whose host exposed no Metal device it
selects a no-op context and surface that draw nothing.
This removes that fallback and instead fails immediately when Metal is
unavailable. This matches the existing runtime behaviour (which already
`FML_CHECK`ed) and the macOS embedder, which refuses to start without a
Metal device.
The no-op path was added in flutter-team-archive/engine#54856 to stop
Impeller-enabled simulators from exiting when no Metal context was
available. That goes back way before we bumped the minimum supported iOS
version to 15. Every device capable of running iOS 15 has a
Metal-capable GPU, and a simulator requires a host with Metal support,
so the fallback isn't necessary and a source of additonal complexity and
possibly bugs from misconfigured environments.
`GPUSurfaceNoop` is now unused and `IOSRenderingAPI` is down to just one
enum value. I'l remove both in followups.
Issue: flutter#1900411 parent ebd8429 commit ae308f5
11 files changed
Lines changed: 15 additions & 230 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
169 | 169 | | |
170 | 170 | | |
171 | 171 | | |
172 | | - | |
173 | | - | |
174 | 172 | | |
175 | 173 | | |
176 | 174 | | |
| |||
179 | 177 | | |
180 | 178 | | |
181 | 179 | | |
182 | | - | |
183 | | - | |
184 | 180 | | |
185 | 181 | | |
186 | 182 | | |
| |||
328 | 324 | | |
329 | 325 | | |
330 | 326 | | |
331 | | - | |
332 | | - | |
333 | 327 | | |
334 | 328 | | |
335 | 329 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
13 | 12 | | |
14 | 13 | | |
15 | 14 | | |
| |||
25 | 24 | | |
26 | 25 | | |
27 | 26 | | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | 27 | | |
36 | 28 | | |
37 | 29 | | |
| |||
This file was deleted.
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| 9 | + | |
9 | 10 | | |
10 | 11 | | |
11 | | - | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | | - | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
32 | 36 | | |
33 | 37 | | |
34 | 38 | | |
| |||
This file was deleted.
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
16 | 15 | | |
17 | 16 | | |
18 | 17 | | |
| |||
0 commit comments