Skip to content

Commit a5a125e

Browse files
committed
Remove the unused GPUSurfaceNoop
`GPUSurfaceNoop` was only ever used by the iOS `IOSSurfaceNoop`, which was deleted when the iOS software-renderer fallback was removed in flutter#190590. Since there are no remaining callers, this removes the class. No behavioural change; the code was already unreachable. The compiler is the test! Issue: flutter#190041
1 parent f0bbd83 commit a5a125e

4 files changed

Lines changed: 1 addition & 196 deletions

File tree

‎engine/src/flutter/shell/gpu/BUILD.gn‎

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -103,8 +103,6 @@ if (shell_enable_metal) {
103103
"gpu_surface_metal_delegate.h",
104104
"gpu_surface_metal_skia.h",
105105
"gpu_surface_metal_skia.mm",
106-
"gpu_surface_noop.h",
107-
"gpu_surface_noop.mm",
108106
]
109107

110108
public_deps = gpu_common_deps
@@ -126,10 +124,7 @@ if (is_mac) {
126124
cflags_objc = flutter_cflags_objc
127125
cflags_objcc = flutter_cflags_objcc
128126

129-
sources = [
130-
"gpu_surface_metal_impeller_unittests.mm",
131-
"gpu_surface_noop_unittests.mm",
132-
]
127+
sources = [ "gpu_surface_metal_impeller_unittests.mm" ]
133128

134129
frameworks = [
135130
"AppKit.framework",

‎engine/src/flutter/shell/gpu/gpu_surface_noop.h‎

Lines changed: 0 additions & 68 deletions
This file was deleted.

‎engine/src/flutter/shell/gpu/gpu_surface_noop.mm‎

Lines changed: 0 additions & 97 deletions
This file was deleted.

‎engine/src/flutter/shell/gpu/gpu_surface_noop_unittests.mm‎

Lines changed: 0 additions & 25 deletions
This file was deleted.

0 commit comments

Comments
 (0)