Repository navigation
Commit 8469ce0
committed
Roll clang to 07d67299a15ce03b053736e2d31a668ee0576987
This rolls clang to pick up
llvm/llvm-project@b8007a8
Xcode 27 Release Candidate 1 includes a new target architecture in the
MacOS SDK .tbd stub files: `arm64e.x1`. The linker in our toolchain
errors out, complaining about the unknown architecture and claiming the
.tbd is malformed. The fix was landed in the above clang commit. This
rolls the updated Fuchsia clang toolchain with the upstream fix.
```
ld64.lld: error: could not load TAPI file at ../../flutter/prebuilts/SDKs/MacOSX27.0.sdk/usr/lib/libSystem.tbd: malformed file
./engine/src/flutter/prebuilts/SDKs/MacOSX27.0.sdk/usr/lib/libSystem.tbd:4:20: error: unknown architecture
arm64e.x1-macos, arm64e.x1-maccatalyst ]
^~~~~~~~~~~~~~~
```
It's been above six months since the last roll. Clang now catches two
new unused identifier warnings (which we promote to errors) in Skia:
* `SkSL::Program::ElementsCollection::iterator::fOwnedEnd` in
`src/sksl/ir/SkSLProgram.h:113` identified due to
`-Wunused-private-field`. Assigned in the iterator's ctor init list at
line 110 but never read.
* `skia::textlayout::ParagraphImpl::getEllipsis()` contains an unused
local `ellipsis16` at `modules/skparagraph/src/ParagraphImpl.cpp:1090`
identified due to `-Wunused-variable`; the `else` branch calls
`fParagraphStyle.getEllipsisUtf16()` again instead of using it.
I've added Skia-specific suppression for those two, and a TODO. I'll
send patches upstream to clean these up. Once they land and Skia rolls
back in, we'll remove the suppression.
Also works around an unused variable warnings in Fuchsia's binding_set.h
until it's fixed upstream in Fuchsia.
This also triggers a warning about `g_test_lock` acquired in
`MockGLES::Init`. This is test-only code either way, but the mutex is
always released in the dtor so the code as written is safe. Added an
annotation to silence that warning.
Issue: flutter#1926091 parent c0f8038 commit 8469ce0
5 files changed
Lines changed: 35 additions & 3 deletions
File tree
- engine/src
- build/config
- flutter
- build/config/skia
- impeller/renderer/backend/gles/test
- shell/platform/fuchsia/dart_runner
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
42 | | - | |
| 42 | + | |
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
532 | 532 | | |
533 | 533 | | |
534 | 534 | | |
| 535 | + | |
| 536 | + | |
| 537 | + | |
| 538 | + | |
535 | 539 | | |
536 | 540 | | |
537 | 541 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| 9 | + | |
9 | 10 | | |
10 | 11 | | |
11 | 12 | | |
| |||
469 | 470 | | |
470 | 471 | | |
471 | 472 | | |
472 | | - | |
| 473 | + | |
473 | 474 | | |
474 | 475 | | |
475 | 476 | | |
| |||
490 | 491 | | |
491 | 492 | | |
492 | 493 | | |
493 | | - | |
| 494 | + | |
494 | 495 | | |
495 | 496 | | |
496 | 497 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
17 | 22 | | |
| 23 | + | |
18 | 24 | | |
19 | 25 | | |
20 | 26 | | |
| |||
0 commit comments