Repository navigation
Commit 26d8833
committed
Impeller: Fix assert on stroked circles wider than their radius
`Tessellator::StrokedCircle` delegated to `GenerateStrokedCircle` whenever
`half_width > 0`, but that generator zig-zags between an inner and an outer
circle and asserts `half_width < radius`, since the inner radius goes
negative once the stroke is at least as wide as the radius. We now treat
that case as what it geometrically is: a filled circle whose radius reaches
the outer edge of the stroke.
This is easy to hit from the framework. With `debugPaintSizeEnabled` set,
`RenderSliver.debugPaint` draws a circle of radius 2.0 with a stroke width
of 4.0, so toggling construction lines on in any build with `FML_DCHECK`
enabled dies immediately with:
```
[FATAL:flutter/impeller/tessellator/tessellator.cc(755)] Check failed: data.half_width > 0 && data.half_width < data.radii.width.
```
`GenerateStrokedArc` has the same problem in a form that doesn't assert: the
inner radii simply go negative and the inner edge folds back through the
centre of the oval, producing a self-intersecting strip. Those are now
clamped to zero.
Fixes: flutter#1905971 parent 99399b2 commit 26d8833
2 files changed
Lines changed: 99 additions & 13 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
506 | 506 | | |
507 | 507 | | |
508 | 508 | | |
509 | | - | |
510 | | - | |
511 | | - | |
512 | | - | |
513 | | - | |
514 | | - | |
515 | | - | |
516 | | - | |
517 | | - | |
518 | | - | |
519 | | - | |
520 | | - | |
| 509 | + | |
521 | 510 | | |
522 | 511 | | |
| 512 | + | |
| 513 | + | |
| 514 | + | |
| 515 | + | |
| 516 | + | |
| 517 | + | |
| 518 | + | |
| 519 | + | |
| 520 | + | |
| 521 | + | |
| 522 | + | |
| 523 | + | |
| 524 | + | |
| 525 | + | |
| 526 | + | |
523 | 527 | | |
524 | 528 | | |
525 | 529 | | |
| |||
858 | 862 | | |
859 | 863 | | |
860 | 864 | | |
861 | | - | |
| 865 | + | |
| 866 | + | |
| 867 | + | |
| 868 | + | |
| 869 | + | |
862 | 870 | | |
863 | 871 | | |
864 | 872 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
303 | 303 | | |
304 | 304 | | |
305 | 305 | | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
306 | 346 | | |
307 | 347 | | |
308 | 348 | | |
| |||
379 | 419 | | |
380 | 420 | | |
381 | 421 | | |
| 422 | + | |
| 423 | + | |
| 424 | + | |
| 425 | + | |
| 426 | + | |
| 427 | + | |
| 428 | + | |
| 429 | + | |
| 430 | + | |
| 431 | + | |
| 432 | + | |
| 433 | + | |
| 434 | + | |
| 435 | + | |
| 436 | + | |
| 437 | + | |
| 438 | + | |
| 439 | + | |
| 440 | + | |
| 441 | + | |
| 442 | + | |
| 443 | + | |
| 444 | + | |
| 445 | + | |
| 446 | + | |
| 447 | + | |
| 448 | + | |
| 449 | + | |
| 450 | + | |
| 451 | + | |
| 452 | + | |
| 453 | + | |
| 454 | + | |
| 455 | + | |
| 456 | + | |
| 457 | + | |
| 458 | + | |
| 459 | + | |
382 | 460 | | |
383 | 461 | | |
384 | 462 | | |
| |||
0 commit comments