Fix resolution of parameterized dictionary subscriptions#457
Merged
Conversation
Signed-off-by: somiljain2006 <[email protected]>
somiljain2006
force-pushed
the
Dictioniary-subscription-bug
branch
from
May 29, 2026 19:33
09be5fd to
00bdf04
Compare
Contributor
Author
|
@n1ckl0sk0rtge Can you review this pr? |
san-zrl
approved these changes
Jun 8, 2026
san-zrl
left a comment
san-zrl
left a comment
Contributor
There was a problem hiding this comment.
- Fixes resolution of parameterized dictionary subscription #10
- Correctly resolves dictionary values (not keys) when parameters are used as indices
- Works with any subscription index type (string, int, bytes) that can be resolved to a literal
- All tests pass in CI and locally (after proper clean build)
- Adds appropriate test coverage for the new functionality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10
Fix the resolution of dictionary subscriptions using function parameters. Preserve argument mappings when resolving subscription expressions and re-resolve outer-scope hook expressions using call-site arguments. This allows expressions such as _curveTable[curve] to resolve through dictionary lookups and correctly identify values like SECP256R1. Added a regression test.