Task #2: Implement BuildOrcSchemaManifest function#7
Merged
Conversation
- Implemented BuildSchemaFieldRecursive helper for depth-first traversal - Walks Arrow schema and ORC type tree in parallel - Assigns column indices using ORC depth-first pre-order (col 0 = root struct) - Marks leaf nodes (primitives) with column_index for statistics - Marks container nodes (struct/list/map) with column_index = -1 - Builds column_index_to_field and child_to_parent lookup maps - Handles struct, list, and map types with proper child matching - Added orc/Type.hh include for ORC type information Implementation details: - Column indexing starts at 1 (column 0 is root struct) - Leaf nodes are primitives that have statistics - Container types recursively process children - Validates ORC root type is STRUCT Verified: Manual code review - follows ORC depth-first pre-order pattern Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Merged
cbb330
added a commit
that referenced
this pull request
Feb 20, 2026
- Implemented BuildSchemaFieldRecursive helper for depth-first traversal - Walks Arrow schema and ORC type tree in parallel - Assigns column indices using ORC depth-first pre-order (col 0 = root struct) - Marks leaf nodes (primitives) with column_index for statistics - Marks container nodes (struct/list/map) with column_index = -1 - Builds column_index_to_field and child_to_parent lookup maps - Handles struct, list, and map types with proper child matching - Added orc/Type.hh include for ORC type information Implementation details: - Column indexing starts at 1 (column 0 is root struct) - Leaf nodes are primitives that have statistics - Container types recursively process children - Validates ORC root type is STRUCT Verified: Manual code review - follows ORC depth-first pre-order pattern Co-authored-by: Claude Sonnet 4.5 <[email protected]>
cbb330
added a commit
that referenced
this pull request
Feb 20, 2026
cbb330
added a commit
that referenced
this pull request
Feb 20, 2026
cbb330
added a commit
that referenced
this pull request
Feb 20, 2026
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
cbb330
added a commit
that referenced
this pull request
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement the schema manifest building logic that maps Arrow schema fields to ORC physical column indices.
Changes
Added
BuildSchemaFieldRecursivehelper function that:Fully implemented
OrcSchemaManifest::Make:Added
#include "orc/Type.hh"for ORC type information accessImplementation Details
ORC Column Indexing:
Type Handling:
Lookup Maps:
column_index_to_field: Fast column → field lookupchild_to_parent: Parent traversal supportTesting
Task Reference
Completes Task #2 from task_list.json - Core Data Structures phase
Depends on Task #1 (complete)
Enables Task #3 (GetOrcColumnIndex function)
Co-Authored-By: Claude Sonnet 4.5 [email protected]