Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
cbb330
added a commit
that referenced
this pull request
Feb 24, 2026
- Added SupportsStatistics helper to check if type supports statistics pushdown - Created PredicateField struct to hold field resolution information - Implemented ResolvePredicateFields to extract and resolve field references from predicates - Currently supports int32 and int64 types - Skips non-leaf fields and unsupported types - Handles nested field resolution correctly Verified: - Resolves field references using FieldsInExpression - Uses GetOrcColumnIndex for ORC column mapping - Handles nested structs by traversing match indices - Returns comprehensive field information for statistics evaluation
cbb330
added a commit
that referenced
this pull request
Feb 24, 2026
Implemented test to verify ORC metadata caching behavior. Tests verify that: 1. Metadata is loaded on first scan 2. Subsequent scans reuse cached metadata (read fewer bytes) 3. ClearCachedMetadata() invalidates the cache 4. Scans after cache clear reload metadata Uses io::TrackedRandomAccessFile to monitor bytes read and verify that cached metadata reduces I/O on subsequent operations. The test validates the metadata caching implementation in OrcFileFragment::EnsureFileMetadataCached(), which lazily loads and caches ORC file metadata to avoid redundant I/O. Verified: Metadata caching works correctly, reducing I/O overhead on repeated scans. Co-authored-by: Claude Sonnet 4.5 <[email protected]>
cbb330
added a commit
that referenced
this pull request
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final update marking Task #9 complete.