Conversation
cbb330
added a commit
that referenced
this pull request
Feb 20, 2026
- Added GetOrcColumnIndex function to resolve FieldRef to ORC column index - Handles top-level fields via direct lookup - Handles nested fields via manifest tree traversal - Returns nullopt if field not found or not a leaf field - Only leaf fields have statistics and valid column indices - Added <optional> include for std::optional support Verified: Code structure follows Parquet pattern
cbb330
added a commit
that referenced
this pull request
Feb 20, 2026
- Implements fast-path row counting using stripe statistics - Returns count directly if predicate can be fully evaluated from metadata - Falls back to full scan (returns nullopt) if statistics insufficient Algorithm: 1. No field refs (e.g., WHERE 1=1): sum all stripe row counts 2. With predicates: evaluate against each stripe via TestStripes - literal(false): exclude stripe from count - literal(true): include stripe row count - partial match: return nullopt (need full scan) Mirrors Parquet's TryCountRows (file_parquet.cc:986-1004) Use case: COUNT(*) WHERE x > 1000 on file with strong statistics can avoid reading data entirely if statistics prove stripes match/exclude. Verified: Logic matches Parquet pattern, uses correct ORC APIs Co-authored-by: Claude Sonnet 4.5 <[email protected]>
cbb330
added a commit
that referenced
this pull request
Feb 20, 2026
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
cbb330
added a commit
that referenced
this pull request
Feb 24, 2026
- Added GetOrcColumnIndex function to resolve FieldRef to ORC column index - Handles top-level fields via direct lookup - Handles nested fields via manifest tree traversal - Returns nullopt if field not found or not a leaf field - Only leaf fields have statistics and valid column indices - Added <optional> include for std::optional support Verified: Code structure follows Parquet pattern
cbb330
added a commit
that referenced
this pull request
Feb 24, 2026
- Implements fast-path row counting using stripe statistics - Returns count directly if predicate can be fully evaluated from metadata - Falls back to full scan (returns nullopt) if statistics insufficient Algorithm: 1. No field refs (e.g., WHERE 1=1): sum all stripe row counts 2. With predicates: evaluate against each stripe via TestStripes - literal(false): exclude stripe from count - literal(true): include stripe row count - partial match: return nullopt (need full scan) Mirrors Parquet's TryCountRows (file_parquet.cc:986-1004) Use case: COUNT(*) WHERE x > 1000 on file with strong statistics can avoid reading data entirely if statistics prove stripes match/exclude. Verified: Logic matches Parquet pattern, uses correct ORC APIs Co-authored-by: Claude Sonnet 4.5 <[email protected]>
cbb330
added a commit
that referenced
this pull request
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task #5 was already implemented as part of Task #4. The StripeStatisticsCache structure includes all required fields and thread safety is provided by the physical_schema_mutex_ from the Fragment base class.