Conversation
cbb330
added a commit
that referenced
this pull request
Feb 20, 2026
cbb330
added a commit
that referenced
this pull request
Feb 20, 2026
- Added ColumnStatistics struct with min/max, null info, and value count - Added GetStripeColumnStatistics(stripe, column) method to ORCFileReader - Added GetTypeName() method to access ORC type tree - Implemented column type traversal using depth-first pre-order indexing - Initial support for int32 and int64 types (INT, LONG, SHORT, BYTE) - Verified: Code compiles with new statistics API This is a critical prerequisite for ORC predicate pushdown implementation. Future work: Add support for float, double, string, and other types. Co-authored-by: Claude Sonnet 4.5 <[email protected]>
cbb330
added a commit
that referenced
this pull request
Feb 20, 2026
- Converts ORC column statistics into guarantee expressions - Handles all-null case (num_values=0): returns is_null(field) - Handles single-value case (min==max): returns field==value with null handling - Handles range case (min<max): returns field in [min, max] with null handling - Validates statistics: ignores deprecated or corrupted stats (min>max) - Returns nullopt for incomplete or missing statistics (conservative fallback) Verified: - Checks is_statistics_deprecated flag before using stats - Properly handles has_null flag for null value inclusion - Validates min <= max to detect corrupted statistics - Uses std::optional for safe failure handling
cbb330
added a commit
that referenced
this pull request
Feb 20, 2026
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
cbb330
added a commit
that referenced
this pull request
Feb 24, 2026
- Added ColumnStatistics struct with min/max, null info, and value count - Added GetStripeColumnStatistics(stripe, column) method to ORCFileReader - Added GetTypeName() method to access ORC type tree - Implemented column type traversal using depth-first pre-order indexing - Initial support for int32 and int64 types (INT, LONG, SHORT, BYTE) - Verified: Code compiles with new statistics API This is a critical prerequisite for ORC predicate pushdown implementation. Future work: Add support for float, double, string, and other types. Co-authored-by: Claude Sonnet 4.5 <[email protected]>
cbb330
added a commit
that referenced
this pull request
Feb 24, 2026
- Converts ORC column statistics into guarantee expressions - Handles all-null case (num_values=0): returns is_null(field) - Handles single-value case (min==max): returns field==value with null handling - Handles range case (min<max): returns field in [min, max] with null handling - Validates statistics: ignores deprecated or corrupted stats (min>max) - Returns nullopt for incomplete or missing statistics (conservative fallback) Verified: - Checks is_statistics_deprecated flag before using stats - Properly handles has_null flag for null value inclusion - Validates min <= max to detect corrupted statistics - Uses std::optional for safe failure handling
cbb330
added a commit
that referenced
this pull request
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates task_list.json to mark Task #3 as complete following successful merge of PR #9.