Add validation for --benchmark-samples to prevent crash with zero value#3041
Closed
chanmyae09 wants to merge 2 commits intocatchorg:develfrom
Closed
Add validation for --benchmark-samples to prevent crash with zero value#3041chanmyae09 wants to merge 2 commits intocatchorg:develfrom
chanmyae09 wants to merge 2 commits intocatchorg:develfrom
Conversation
chanmyae09
force-pushed
the
fix-benchmark-samples-validation
branch
from
a75ac05 to
84a8fc4
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## devel #3041 +/- ##
==========================================
- Coverage 91.05% 91.03% -0.03%
==========================================
Files 202 202
Lines 8716 8725 +9
==========================================
+ Hits 7936 7942 +6
- Misses 780 783 +3 🚀 New features to boost your workflow:
|
Member
|
Needs an automated test. |
chanmyae09
force-pushed
the
fix-benchmark-samples-validation
branch
from
84a8fc4 to
ff7fe4a
Compare
Contributor
|
I picked this up and opened a new PR that includes the fix and updated approval baselines #3056 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3040
Summary
Added validation to reject
--benchmark-samples 0which was causing a segmentation fault.Changes
Testing
Tested with a benchmark test case - now shows error message "Benchmark samples must be greater than 0" instead of crashing with SIGSEGV.