Allow composability of unhandled exception filters on Windows#3033
Merged
horenmar merged 1 commit intocatchorg:develfrom Sep 27, 2025
Merged
Allow composability of unhandled exception filters on Windows#3033horenmar merged 1 commit intocatchorg:develfrom
horenmar merged 1 commit intocatchorg:develfrom
Conversation
dunhor
changed the title
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## devel #3033 +/- ##
==========================================
- Coverage 90.77% 90.75% -0.02%
==========================================
Files 201 201
Lines 8707 8709 +2
==========================================
Hits 7903 7903
- Misses 804 806 +2 🚀 New features to boost your workflow:
|
Member
|
Thanks. It was always supposed to do that, but back when we used VectoredExceptionHandler (?) we would only need to return |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Situation
Currently, I'm doing some long overdue investigations of some test reliability. The unfortunate thing is that failures almost exclusively come from CI builds. Some of these failures are crashes. In such cases, it would be very beneficial to get a stacktrace printed out in the output, however this is proving tricky because Catch2 is calling
SetUnhandledExceptionFilterand overriding the handler I'm trying to install.The Change
The change is very simple. If a handler previously existed, Catch2 will invoke it after printing out its output. I've also updated the comment to better reflect that it's returning
EXCEPTION_CONTINUE_SEARCHeven in scenarios where the exception is one that the library cares about.