Move more of tostring.hpp into source file and remove tuple printing recursion#3028
Merged
horenmar merged 3 commits intocatchorg:develfrom Oct 4, 2025
Merged
Move more of tostring.hpp into source file and remove tuple printing recursion#3028horenmar merged 3 commits intocatchorg:develfrom
horenmar merged 3 commits intocatchorg:develfrom
Conversation
ZXShady
force-pushed
the
more_stringifying
branch
from
d9ce4a6 to
47af6df
Compare
ZXShady
changed the title
ZXShady
force-pushed
the
more_stringifying
branch
2 times, most recently
from
8d4633c to
4de4836
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## devel #3028 +/- ##
==========================================
- Coverage 91.08% 91.05% -0.03%
==========================================
Files 202 202
Lines 8715 8716 +1
==========================================
- Hits 7938 7936 -2
- Misses 777 780 +3 🚀 New features to boost your workflow:
|
ZXShady
force-pushed
the
more_stringifying
branch
from
4de4836 to
7043ddc
Compare
Member
|
Let's not reformat everything. As I understand it, there are three separate changes
Can you provide the PR with just these changes? Alternatively I can pick the changes later. |
horenmar
force-pushed
the
more_stringifying
branch
from
7043ddc to
2718aec
Compare
Contributor
Author
|
Hi sorry, I was away from my computer for this week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I moved more stuff into the .cpp file and formatted the file and I removed recursion from the tuple printer for better compile times and readability.