CatchMiscFunctions.cmake: Use PRIVATE for target_compile_options#2553
Merged
horenmar merged 2 commits intocatchorg:develfrom Oct 24, 2022
Merged
Conversation
If PUBLIC is used INTERFACE_COMPILE_OPTIONS is populated. Definition of INTERFACE_COMPILE_OPTIONS: 'Targets may populate this property to publish the compile options required to compile against the headers for the target.' But this is not be true for -ffile-prefix-map.
Codecov Report
@@ Coverage Diff @@
## devel #2553 +/- ##
=======================================
Coverage 91.15% 91.15%
=======================================
Files 185 185
Lines 7614 7614
=======================================
Hits 6940 6940
Misses 674 674 |
horenmar
reviewed
Oct 23, 2022
horenmar
added
the
Building and Packaging
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If PUBLIC is used INTERFACE_COMPILE_OPTIONS is populated. Definition of INTERFACE_COMPILE_OPTIONS: 'Targets may populate this property to publish the compile options required to compile against the headers for the target.' But this is not be true for -ffile-prefix-map.