Prepare for CRAN submission#715
Merged
Merged
Conversation
with autoconfig mechanis. Intermediate files are Git ignored.
…change in Makefile.win was required not to rebuild it if present already. Git ignores fixed
Synchronize configure.ac to be inline with Windows build. Regenerate configure
… file pointed is copied into src/
…opy pointed DLL into src/libcatboostr.dll
…ng while checking package
…eck complains. Regenerate NAMESPACE. Fix issues with documentation: skip building Rd for internal functions in catboost.caret.R, document parameters in catboost.drop_unused_features Regenerate man files
…real core number) causes assertion in catboost.train
…in function naming
Add .lintr to .Rbuildignore not to interfere with package check. Fix lines over 150 characters in catboost.R
- Date removed from DESCRIPTION: redundant and not recommended - URL and BugFixes added to DESCRIPTION - Author contains all people and contributors - Title fixed to describe that package is for - Maintainer restored - require removed from catboost.R in favor to @import - got rid of sapply in favor to vapply
ADD cran-comments.md to .Rbuildignores not to disturb package checks
Change line endings to Windows in Documentation
Replace Arch to Binarch in DESCRIPTION as Arch is non standard Change line endings from Windows to Linux
Apply any to is.na(modelFit$lev) in catboost.caret$predict: modelFit$lev is definitely of length > 1
Conflicts: catboost/R-package/DESCRIPTION catboost/R-package/R/catboost.R catboost/R-package/man/catboost.drop_unused_features.Rd catboost/R-package/tests/testthat/test_model.R
Open
ws171913
marked this pull request as ready for review
March 4, 2019 09:30
Contributor
|
@arcadia-devtools Ship it! |
Collaborator
Contributor
Author
|
Once again :) |
Collaborator
Collaborator
|
Check 751511 passed |
exprmntr
reviewed
Mar 4, 2019
|
|
||
| ##### INIT #################################################################### | ||
|
|
||
| AC_INIT(catboost, 0.12, [email protected]) |
Contributor
There was a problem hiding this comment.
Can we specify https://github.com/catboost/catboost/issues as a bug report page instead of [email protected]?
exprmntr
reviewed
Mar 4, 2019
confugure should be regenerated with autoconf command
Contributor
|
@arcadia-devtools Ship it! |
Collaborator
Collaborator
|
Check 751511 passed |
Contributor
Author
|
We started submitting it on CRAN, but on their validation environment
errors occurred which we could not reproduce.
We'll try again shortly.
wt., 16 cze 2020 o 15:19 Lorenz Walthert <[email protected]>
napisał(a):
… @ws171913 <https://github.com/ws171913> any plans for making this
available via CRAN? A lot of people only use packages that are distributed
via CRAN.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#715 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHVEV5MTOJOGS7BRIDSBZ5TRW5WOVANCNFSM4G3PTRAA>
.
|
|
Thanks for the update. Have you tried to use docker containers from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: [https://yandex.ru/legal/cla/?lang=en]