Add skip_train option for metrics#662
Merged
Merged
Conversation
annaveronika
suggested changes
Feb 6, 2019
| @@ -299,7 +303,6 @@ static void DisableMetricSkipTrain(NJson::TJsonValue* metric) { | |||
| } | |||
| hints["skip_train"] = "false"; | |||
| params["hints"] = MakeHintsDescription(hints); | |||
Contributor
There was a problem hiding this comment.
DisableMetricSkipTrain is now not needed.
| assert "test-AUC-mean" in results | ||
| return local_canonical_file(remove_time_from_json(JSON_LOG_PATH)) | ||
|
|
||
| def test_cv_skip_train(task_type): |
Contributor
There was a problem hiding this comment.
Please also add test with AUC which has default skip_train=True and check that there is no train in results.
| DisableMetricsSkipTrain(&updatedTrainOptionsJson); | ||
|
|
||
|
|
||
| // TODO(nikitxskv): Remove this hot-fix and make correct skip-metrics support in cv. |
Contributor
There was a problem hiding this comment.
This TODO should be removed
Contributor
|
Thanks a lot for the changes! There were some updates in code, could you resolve the conflicts? |
Member
|
@arcadia-devtools Ship it! |
Collaborator
|
@andrey-khropov, internal review request created: 736861 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added skip_train options for metrics in cross validation.
I hereby agree to the terms of the CLA available at https://yandex.ru/legal/cla/?lang=en.