add input/output borders files support from python package#656
Merged
arcadia-devtools merged 3 commits intoFeb 14, 2019
Conversation
Contributor
|
@arcadia-devtools Ship it! |
Contributor
|
please agree to the cla, see exaples in other pr-s |
Evgueni-Petrov-aka-espetrov
approved these changes
Feb 2, 2019
| cdef EPredictionType EPredictionType_Probability "EPredictionType::Probability" | ||
| cdef EPredictionType EPredictionType_RawFormulaVal "EPredictionType::RawFormulaVal" | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
Please undo whitespace change
Collaborator
|
@annaveronika, internal review request created: 701583 |
Contributor
|
@necnec Could you please resolve the conflicts? |
Contributor
|
@necnec Do you plan to proceed with the pr? |
Closed
|
@necnec Please, fix the conflict, it's very quick. I can do it for you, if you give me write access or I can create my PR with your code, if you don't mind. |
Member
|
@arcadia-devtools Ship it! |
1 similar comment
Contributor
|
@arcadia-devtools Ship it! |
Collaborator
|
@annaveronika, internal review request created: 724218 |
Contributor
|
@necnec Thank you very much for contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
During training and prediction, CatBoost splits the range of values of each floating point feature into intervals, and uses these intervals instead of the true values.
Using the same feature borders during training and prediction improves prediction accuracy.
Currently python users can neither save feature borders after training, nor load them during prediction; while this is possible with the command-line CatBoost tool.
Your task is to close this gap.
You need to add input_borders_file and output_borders_file parameters to classes CatBoost* in the CatBoost python package, and pass them via cython to the C++ implementation.