Skip to content

Task 12. adding new options for output#646

Merged
annaveronika merged 3 commits into
catboost:masterfrom
towelenee:forward_prediction
Feb 2, 2019
Merged

Task 12. adding new options for output#646
annaveronika merged 3 commits into
catboost:masterfrom
towelenee:forward_prediction

Conversation

@towelenee

@towelenee towelenee commented Feb 2, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

@towelenee towelenee changed the title Task 14. adding new options for output Task 12. adding new options for output Feb 2, 2019
@Noxoomo

Noxoomo commented Feb 2, 2019

Copy link
Copy Markdown
Member

@arcadia-devtools Ship It!

@annaveronika

annaveronika commented Feb 2, 2019

Copy link
Copy Markdown
Contributor

Please agree to our cla, here is an example #644

@annaveronika

annaveronika commented Feb 2, 2019

Copy link
Copy Markdown
Contributor

@arcadia-devtools Ship it!

@arcadia-devtools

arcadia-devtools commented Feb 2, 2019

Copy link
Copy Markdown
Collaborator

@annaveronika, internal review request created: 701505

@annaveronika

annaveronika commented Feb 2, 2019

Copy link
Copy Markdown
Contributor

@arcadia-devtools Ship it!

@arcadia-devtools

arcadia-devtools commented Feb 2, 2019

Copy link
Copy Markdown
Collaborator

@annaveronika, internal review request created: 701589

@annaveronika
annaveronika merged commit 593ed5f into catboost:master Feb 2, 2019
@annaveronika annaveronika mentioned this pull request Feb 2, 2019
Merged
@annaveronika

annaveronika commented Feb 6, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

test test_write_predictions_to_streams is failing:

catboost/pytest/test.py:6035: in test_write_predictions_to_streams
    yatest.common.execute(calc_cmd)
library/python/testing/yatest_common/yatest/common/process.py:442: in execute
    res.wait(check_exit_code, timeout, on_timeout)
library/python/testing/yatest_common/yatest/common/process.py:308: in wait
    self._finalise(check_exit_code)
library/python/testing/yatest_common/yatest/common/process.py:315: in _finalise
    raise ExecutionError(self)
E   ExecutionError: Command 'https://proxy.sandbox.yandex-team.ru/824860380/build-release/catboost.tar/catboost/app/catboost calc --input-path arcadia/catboost/pytest/data/adult/test_small --column-description arcadia/catboost/pytest/data/adult/train.cd -m http://download-distbuild.n.yandex-team.ru/mds/192583/results_merger-11291198702365356620-0-5AC-528474/catboost/pytest/test-results/catboost-pytest/default-linux-x86_64-release-ALLOCATOR%3DLF-DEBUGINFO_LINES_ONLY%3Dyes-NO_DEBUGINFO%3Dno-TRAVERSE_RECURSE_FOR_TESTS%3Dyes-USE_EAT_MY_DATA%3Dyes-asan/testing_out_stuff.tar/2/testing_out_stuff/test.py.test_write_predictions_to_streams/model.bin --output-path stream://stdout > http://download-distbuild.n.yandex-team.ru/mds/192583/results_merger-11291198702365356620-0-5AC-528474/catboost/pytest/test-results/catboost-pytest/default-linux-x86_64-release-ALLOCATOR%3DLF-DEBUGINFO_LINES_ONLY%3Dyes-NO_DEBUGINFO%3Dno-TRAVERSE_RECURSE_FOR_TESTS%3Dyes-USE_EAT_MY_DATA%3Dyes-asan/testing_out_stuff.tar/2/testing_out_stuff/test.py.test_write_predictions_to_streams/calc_test.eval' has failed with code 1.
E   Errors:
E   (NLastGetopt::TUsageException) library/getopt/small/last_getopt_parser.cpp:69: required exactly 0 free args
E   Try 'https://proxy.sandbox.yandex-team.ru/824860380/build-release/catboost.tar/catboost/app/catboost calc --help' for more information.

@annaveronika

annaveronika commented Feb 6, 2019

Copy link
Copy Markdown
Contributor

And pep8 check says:

arcadia/catboost/pytest/test.py:6009:1: E302 expected 2 blank lines, found 1
def test_write_predictions_to_streams():
^
arcadia/catboost/pytest/test.py:6013:1: W293 blank line contains whitespace

^
arcadia/catboost/pytest/test.py:6051:1: W293 blank line contains whitespace

^
arcadia/catboost/pytest/test.py:6051:1: W391 blank line at end of file

^

@towelenee

towelenee commented Feb 6, 2019

Copy link
Copy Markdown
Contributor Author

@annaveronika Why would yatest.common.test_output_path('calc_test.eval') create a http address?

@annaveronika

annaveronika commented Feb 6, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

This pull request was accidentally merged (its first version) and reverted later. Could you please create one more pr, and we'll discuss all questions there?

@annaveronika

annaveronika commented Feb 6, 2019

Copy link
Copy Markdown
Contributor

yatest.common.test_output_path('calc_test.eval') should create path to a local folder "testing_out_stuff" where files that you generate can be stored. It should not be http address.

@kizill

kizill commented Feb 6, 2019

Copy link
Copy Markdown
Member

This pull request is already nerged and i've fixed tests during internal merge with GitHub. There is nothing to do in this PR now. Thank you a lot for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@towelenee @Noxoomo @annaveronika @arcadia-devtools @kizill @Qwicen