Skip to content

Replace -X/-Y in CLI with --cv catboost_clickhouse_sprint_02.02.2019 …#644

Merged
kizill merged 5 commits into
catboost:masterfrom
tswr:master
Feb 4, 2019
Merged

Replace -X/-Y in CLI with --cv catboost_clickhouse_sprint_02.02.2019 …#644
kizill merged 5 commits into
catboost:masterfrom
tswr:master

Conversation

@tswr

@tswr tswr commented Feb 2, 2019

Copy link
Copy Markdown

Remove -X/-Y from CLI. Replace with --cv Classical:n;k and --cv Inverted:n;k.

Note that docs at https://tech.yandex.com/catboost/doc/dg/concepts/cli-reference_cross-validation-docpage/ should be updated as follows.

Execution format

catboost fit -f <file path> [--cv <value>] [--cv-rand <value>] [other parameters]

Options
...
--cv 
Perform cross validation to score the model. Supports two modes. Classical: perform cross validation to score the model by excluding a small fold from the training dataset and using it for testing. Inverted: perform cross validation to score the model by excluding a small fold from the validation dataset and using it for training.

Format for specifying values:

<cvtype>:<n>;<k>
cvtype is either Classical or Inverted.
 n is the identifier of the fold to exclude.
 k is the number of folds to split the input data into.
The inequality n < k must be true.

For example, to exclude the fold indexed 13 from the training dataset and use it for testing, set the value Classical:13;15. To exclude the fold indexed 13 from the validation dataset and use it for training, set the value Inverted:13;15.

The data is randomly shuffled before splitting.

--cv-rand
...
It must be used with --cv <value> parameter.

--
I hereby agree to the terms of the CLA available at https://yandex.ru/legal/cla/?lang=en.

@annaveronika

Copy link
Copy Markdown
Contributor

@arcadia-devtools Ship it!

@annaveronika

Copy link
Copy Markdown
Contributor

@arcadia-devtools Ship it!

1 similar comment
@annaveronika

Copy link
Copy Markdown
Contributor

@arcadia-devtools Ship it!

@arcadia-devtools

Copy link
Copy Markdown
Collaborator

@annaveronika, internal review request created: 701499

@annaveronika

Copy link
Copy Markdown
Contributor

@arcadia-devtools Ship it!

@arcadia-devtools

Copy link
Copy Markdown
Collaborator

@annaveronika, internal review request created: 701515

@annaveronika

Copy link
Copy Markdown
Contributor

@arcadia-devtools Ship it!

@arcadia-devtools

Copy link
Copy Markdown
Collaborator

@annaveronika, internal review request created: 701529

Comment thread catboost/pytest/test.py
'-T', '4',
'-m', output_model_path,
('-Y' if is_inverted else '-X'), '2/10',
'--cv', format_crossvalidation(is_inverted, 2, 10),

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

можешь пожалуйста еще такие же изменения тестов добавить в pytest/cuda_test/test_gpu.py

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

да, исправил

@annaveronika

Copy link
Copy Markdown
Contributor

@arcadia-devtools Ship it!

1 similar comment
@annaveronika

Copy link
Copy Markdown
Contributor

@arcadia-devtools Ship it!

@arcadia-devtools

Copy link
Copy Markdown
Collaborator

@annaveronika, internal review request created: 701591

@kizill
kizill merged commit 1e7bac3 into catboost:master Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants