Skip to content

Optimize Lossguide#2883

Closed
Levachev wants to merge 39 commits into
catboost:masterfrom
Levachev:dev
Closed

Optimize Lossguide#2883
Levachev wants to merge 39 commits into
catboost:masterfrom
Levachev:dev

Conversation

@Levachev
Copy link
Copy Markdown
Contributor

Optimizing Lossguide with the subtract trick.

When testing, it was found that the result will be different(compared to the master version) if you do not set the parameters of CatBoostRegressor
random_strength=0,
bootstrap_type="No",
has_time=True
Otherwise, the result will be different due to the fact that Ctx->LearnProgress->Rand.GenRand() will be different when splitting the leaf

@Levachev
Copy link
Copy Markdown
Contributor Author

I hereby agree to the terms of the CLA available at: link.

@Evgueni-Petrov-aka-espetrov
Copy link
Copy Markdown
Contributor

copy of #2835 which cannot be merged automatically because of sync engine update

@Evgueni-Petrov-aka-espetrov
Copy link
Copy Markdown
Contributor

Shipped!

@Levachev
Copy link
Copy Markdown
Contributor Author

I hereby agree to the terms of the CLA available at: link.

@Evgueni-Petrov-aka-espetrov
Copy link
Copy Markdown
Contributor

Shipped!

@robot-magpie
Copy link
Copy Markdown

robot-magpie Bot commented May 28, 2025

❌ Missing CLA from one or more contributors

Thanks for your pull request! In order for us (YANDEX LLC) to accept patches and other contributions from you,
you will have to adopt our Yandex Contributor License Agreement (the "CLA").

See CONTRIBUTING.md for more info about Yandex Contributor License Agreement.


The following contributors were found:
b3cc3f4 Author: @Levachev (r.*****[email protected],1375*********[email protected])

(Only the first commit for a unique contributor is listed)

@Levachev
Copy link
Copy Markdown
Contributor Author

I hereby agree to the terms of the CLA available at: link.

@Levachev
Copy link
Copy Markdown
Contributor Author

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=ru

@robot-magpie
Copy link
Copy Markdown

robot-magpie Bot commented May 29, 2025

✅ All contributors are covered under a CLA with Yandex

See CONTRIBUTING.md for more info about Yandex Contributor License Agreement.


The following contributors were found:
b3cc3f4 Author: @Levachev (r.*****[email protected],1375*********[email protected])

(Only the first commit for a unique contributor is listed)

@Evgueni-Petrov-aka-espetrov
Copy link
Copy Markdown
Contributor

Shipped!

@robot-magpie
Copy link
Copy Markdown

robot-magpie Bot commented May 29, 2025

@Evgueni-Petrov-aka-espetrov has triggered the import of a pull request, but it hasn't started. If you are a Yandex employee, you can view the log.

@Evgueni-Petrov-aka-espetrov
Copy link
Copy Markdown
Contributor

Shipped!

@robot-magpie
Copy link
Copy Markdown

robot-magpie Bot commented May 29, 2025

@Evgueni-Petrov-aka-espetrov has imported your pull request. If you are a Yandex employee, you can view this diff.

@robot-magpie
Copy link
Copy Markdown

robot-magpie Bot commented May 30, 2025

✅ This pull request is being closed because it has been successfully merged into our internal monorepository.
Your changes will be pushed to this repository soon. Thank you for your contribution!

@robot-magpie robot-magpie Bot closed this May 30, 2025
robot-piglet pushed a commit that referenced this pull request May 30, 2025
Optimizing Lossguide with the subtract trick.

When testing, it was found that the result will be different(compared to the master version) if you do not set the parameters of CatBoostRegressor
random_strength=0,
bootstrap_type="No",
has_time=True
Otherwise, the result will be different due to the fact that Ctx->LearnProgress->Rand.GenRand() will be different when splitting the leaf

---
Co-authored-by: Levachev [[email protected]]

Pull Request resolved: #2883

Co-authored-by: espetrov <[email protected]>
commit_hash:eb90d7e7d00a4e328bd770507c73a7e1f305145e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants