Still working on building the code locally, I'd also like to get some info about how to better test it :)

I am able to build the Python wheel via python3 setup.py bdist_wheel. Need to find a minimal test to verify the new code.

Please, agree to the CLA.

I am able to build the Python wheel via python3 setup.py bdist_wheel. Need to find a minimal test to verify the new code.

See the documentation about the tests

@andrey-khropov Hi! Thanks a lot for the feedback! I have a couple of questions:

1. I am using the python wrapper to build with cmake, but from the test docs it seems that I'd need to run cmake directly to build a specific test. What would you use to build utils/system/info_ut.cpp ? I get what the target should be (util-system-info-ut) but I can't make cmake work :(
2. To properly test the code I'd need to mock some sysfs files, or to somehow create tmp files with the content that I want and inject them in the code (in this case, in static/internal methods). I am not 100% familiar with how to do this in cpp/catboost, do you have any example/recommendation?

I am still trying to figure out how to run tests (reading https://catboost.ai/en/docs/concepts/development-and-contributions#run-tests), any suggestion?

I tried:

cmake .
cmake --build . --target help

But I can't find anything that is related to the info.cpp ut test file..

@andrey-khropov Hi! Thanks a lot for the feedback! I have a couple of questions:

1. I am using the python wrapper to build with cmake, but from the test docs it seems that I'd need to run cmake directly to build a specific test. What would you use to build `utils/system/info_ut.cpp` ? I get what the target should be (`util-system-info-ut`) but I can't make cmake work :(

2. To properly test the code I'd need to mock some sysfs files, or to somehow create tmp files with the content that I want and inject them in the code (in this case, in static/internal methods). I am not 100% familiar with how to do this in cpp/catboost, do you have any example/recommendation?

Somehow CMake build for unittests in catboost/util in particular seems to be non-working. I'll look into it: #2525 . I'm sorry.

Thanks! I'll concentrate on finding a good unit test for the new code :)

I don't have a better idea to test this than to run a special unit test that prints the number of cpus with different container specs. It will be a one-off, but it is inline with the current tests for util/info. If there is a way to mock some sysfs file contents in the unit tests we may be able to have something better, but I don't have any expertise in c++ testing so I'd need some guidance.

Built the static library of catboost and used the following to test cgroups v2:

#include "util/system/info.h"
#include "stdio.h"

int main() {
    long int cpus = NSystemInfo::NumberOfCpus();
    printf("CPUs: %ld\n", cpus);
}

On Debian Bookworm (default is using cgroups v2) I tested:

• docker run --cpus=2 -it -v $(pwd):/test debian:bookworm (CPUS: 2)
• docker run --cpus=0.5 -it -v $(pwd):/test debian:bookworm (CPUS: 1)
• docker run -it -v $(pwd):/test debian:bookworm (CPUS: 8, max present on my laptop)

I agree with the CLA outlined in https://yandex.ru/legal/cla/?lang=en

@andrey-khropov thanks! Sent a new patch with variables in camel case and the ) on the previous line. Re-tested as explained above as well.

@andrey-khropov thanks a lot for the approval, what is the next step? Should I help/work on #2525 ?

Gentle ping, not sure what to do folks :)

Gentle ping, not sure what to do folks :)

I've discovered some strange buffer underflow issue when I tried to merge this PR but it is not related to your changes directly, I'm investigating. You don't have to do anything for now.

Gentle ping, not sure what to do folks :)

I've discovered some strange buffer underflow issue when I tried to merge this PR but it is not related to your changes directly, I'm investigating. You don't have to do anything for now.

Thanks a lot! I asked since I thought the code may have needed more reviewers, and where I work (Wikimedia foundation) we are trying to solve a k8s performance bug when running catboost with cgroups v2. Nothing urgent but ideally we'll love to work with you to have a new minor release in Pypi with the patch to fix the issue :)

Gentle ping, not sure what to do folks :)

I've discovered some strange buffer underflow issue when I tried to merge this PR but it is not related to your changes directly, I'm investigating. You don't have to do anything for now.

Thanks a lot! I asked since I thought the code may have needed more reviewers, and where I work (Wikimedia foundation) we are trying to solve a k8s performance bug when running catboost with cgroups v2. Nothing urgent but ideally we'll love to work with you to have a new minor release in Pypi with the patch to fix the issue :)

Yes, CatBoost 1.2.3 that is expected to contain this change is planned to be released this week.

@andrey-khropov Hi! Is there anything still pending or shall we merge this? Thanks in advance :)