Repository navigation
fix(run_tests): report structured results for a failed run (#1169) - #1226
Merged
catatafishen merged 2 commits intoNov 9, 2026
Merged
catatafishen merged 2 commits into
catatafishen merged 2 commits into
Conversation
A run with a non-zero exit code returns only the bounded console capture, even when the IDE's test-results model has counts and the failing tests for this run (catatafishen#1169). Co-Authored-By: Claude Opus 5.5 <[email protected]>
A run with a non-zero exit code skipped the IDE's test-results model and returned only the bounded console capture, so the run that most needs counts and failing-test messages got a truncated raw dump (catatafishen#1169). The skip guarded against reading an earlier tab of the same configuration. That guard now lives in descriptor matching: the run tab is the one whose process handler is this run's; for a failed run there is no by-name fallback. Output without test counts still gives way to this run's captured console. Co-Authored-By: Claude Opus 5.5 <[email protected]>
nightlab-agent
requested a deployment
to
fuzzing-gate
November 8, 2026 22:10 — with 
GitHub Actions
Waiting
GitHub Actions
Waiting
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
catatafishen
approved these changes
Nov 9, 2026
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1169.
selectTestOutputskipped the IDE's test-results model whenever the exit code was non-zero, so a failing run, the one whose failures matter most, returned only the bounded console capture (truncated,##teamcity[...]lines, no counts).What changed (
RunTestsTool.java):findTestRunDescriptor: the tab whose process handler is this run's wins, and for a failed run there is no by-name fallback, so stale passing results cannot hide the failure.Tests (
RunTestsToolResultCollectionTest):failedRunReportsThisRunsStructuredResultsInsteadOfTheRawConsolefails without the fix and passes with it; two more cover the descriptor choice (theTabOfThisRunWinsOverASameNamedEarlierTab,failedRunNeverReadsAnEarlierTabOfTheSameConfiguration).What did not run here: my build machine cannot reach
artifacts-caching-proxy.aws.intellij.net, soinstrumentCode(asm-all) was switched off in a local edit for these runs; that edit is not in this PR. On the currentmaster(2e69e35), rebased: the new test fails on the test-only commit (10 run, 1 failed) and the class passes with the fix (12 of 12). The full:plugin-core:testrun was done before the rebase, on 7d6eba7, not again here: with the fix it had 39 failures, all inMcpProtocolHandlerTestandMcpProtocolHandlerStaticMethodsTest(anExceptionInInitializerErrorfrom aClassCastExceptionin setup); the same 39, by name, failed on 7d6eba7 without the fix with the same local edit, so I read them as this machine's setup rather than this change.:plugin-core:buildPluginand the MCP server tests did not run here.Disclosure: this PR was written by Nightlab, an AI agent (Claude), and checked by the same agent; a human did not review it before it was opened.
This pull request was written by Nightlab, an AI agent (https://github.com/nightlab-agent). Before opening it, Nightlab ran
bash /nightlab/runs/2026-11-08/scratch/ab1169/door-test.shon this branch and it passed. If AI-written contributions are not welcome here, close it and Nightlab will not open another pull request on this repository.