PHP 8.2 and 8.3 compatibility by remicollet · Pull Request #18 · cataphract/php-rar

remicollet · 2022-09-15T08:29:56Z

Without, test suite fails with

TEST 2/115 [tests/002.phpt]
========DIFF========
001+ Warning: RarArchive::__toString() implemented without string return type in Unknown on line 0
002+ 
003+ Warning: RarEntry::__toString() implemented without string return type in Unknown on line 0
     array(2) {
       [0]=>
       object(RarEntry)#%d (%d) {
--
========DONE========
FAIL rar_list() function [tests/002.phpt]

With this fix

=====================================================================
PHP         : /opt/remi/php82/root/usr/bin/php 
PHP_SAPI    : cli
PHP_VERSION : 8.2.0RC2
ZEND_VERSION: 4.2.0RC2
PHP_OS      : Linux - Linux builder.remirepo.net 5.19.8-100.fc35.x86_64 #1 SMP PREEMPT_DYNAMIC Thu Sep 8 19:23:03 UTC 2022 x86_64
INI actual  : /work/GIT/pecl-and-ext/rar/tmp-php.ini
More .INIs  :  
---------------------------------------------------------------------
PHP         : /opt/remi/php82/root/usr/bin/php-cgi 
PHP_SAPI    : cgi-fcgi
PHP_VERSION : 8.2.0RC2
ZEND_VERSION: 4.2.0RC2
PHP_OS      : Linux - Linux builder.remirepo.net 5.19.8-100.fc35.x86_64 #1 SMP PREEMPT_DYNAMIC Thu Sep 8 19:23:03 UTC 2022 x86_64
INI actual  : /work/GIT/pecl-and-ext/rar/tmp-php.ini
More .INIs  : 
--------------------------------------------------------------------- 
CWD         : /work/GIT/pecl-and-ext/rar
Extra dirs  : 
VALGRIND    : Not used
=====================================================================
TIME START 2022-09-15 08:26:08
=====================================================================
PASS rar_open() function [tests/001.phpt] 
PASS rar_list() function [tests/002.phpt] 
PASS rar_entry_get() function [tests/003.phpt] 
PASS RarEntry::extract() method [tests/004.phpt] 
PASS rar_comment_get() function [tests/005.phpt] 
PASS RarEntry::getCrc() method in multi-volume archives (PECL bug #9470) [tests/006.phpt] 
PASS rar_open() function with a non-RAR [tests/007.phpt] 
PASS rar_entry_get() function [tests/008.phpt] 
PASS RarEntry::getName() function with unicode filenames [tests/009.phpt] 
PASS RarEntry::getStream() function (good RAR file, one volume) [tests/010.phpt] 
PASS RarEntry::getStream() function (good RAR file, several volumes) [tests/011.phpt] 
PASS RarEntry::getStream() function (bad RAR file) [tests/012.phpt] 
PASS rar_entry_get() and RarEntry::getName() coherence [tests/013.phpt] 
PASS RarEntry::getStream() on unicode entry [tests/014.phpt] 
PASS rar_close() liberates resource (PECL bug #9649) [tests/015.phpt] 
PASS RarEntry::extract() method (corrupt RAR file) [tests/016.phpt] 
PASS RarEntry::extract() with unicode files [tests/017.phpt] 
PASS rar_list()/rar_entry_get() with not first volume [tests/018.phpt] 
PASS RarEntry::getStream() function (store method) [tests/019.phpt] 
PASS RarEntry::getStream() function (solid archive) [tests/020.phpt] 
PASS RarEntry::isDirectory() basic test [tests/021.phpt] 
PASS RarEntry::extract() with directory [tests/022.phpt] 
PASS RarEntry::getStream() with directory [tests/023.phpt] 
PASS rar_open()/RarEntry::getStream() (headers level password) [tests/024.phpt] 
PASS rar_open()/RarEntry::extract() (headers level password) [tests/025.phpt] 
PASS RarEntry::getStream() (file level password) [tests/026.phpt] 
PASS RarEntry::getStream() with Linux directories and links [tests/027.phpt] 
PASS RarArchive::open() basic test [tests/028.phpt] 
PASS RarArchive::getEntries() basic test [tests/029.phpt] 
PASS RarArchive::getEntry() basic test [tests/030.phpt] 
PASS RarArchive::getComment() basic test [tests/031.phpt] 
PASS RarArchive traversal with multi-part archive [tests/032.phpt] 
PASS rar_solid_is() basic test [tests/033.phpt] 
PASS RarException::(set/is)UsingExceptions() test [tests/034.phpt] 
PASS rar_entry_get() non-existent file with exceptions [tests/035.phpt] 
PASS rar_open() non-existent archive with exceptions [tests/036.phpt] 
PASS RarEntry::getStream(), password not given, with exceptions [tests/037.phpt] 
PASS RarArchive get iterator on closed file [tests/038.phpt] 
PASS Access RAR archive with missing volumes [tests/039.phpt] 
SKIP RarEntry::getUnpackedSize() on platforms with 32-bit longs [tests/040.phpt] reason: this test is for 32bit platforms only
PASS RarEntry::getUnpackedSize() on platforms with 64-bit longs [tests/041.phpt] 
PASS rar_open() with volume find callback basic test [tests/042.phpt] 
PASS rar_open() with volume find (callback variants 1) [tests/043.phpt] 
PASS rar_open() with volume find (callback variants 2) [tests/044.phpt] 
PASS rar_open() with invalid volume callback [tests/045.phpt] 
PASS RarEntry::getStream() function (broken set fixed with volume callback) [tests/046.phpt] 
PASS RarEntry::extract() function (broken set fixed with volume callback) [tests/047.phpt] 
SKIP RarArchive::open() volume callback long return (case MAXPATHLEN <= NM) [tests/048.phpt] reason: ; this test is for systems where MAXPATHLEN <= 1024
PASS RarArchive::open() volume callback long return (case MAXPATHLEN > NM) [tests/049.phpt] 
PASS Stream wrapper basic test [tests/050.phpt] 
PASS Stream wrapper relative path test [tests/051.phpt] 
PASS Stream wrapper archive/file not found [tests/052.phpt] 
PASS Stream wrapper malformed url [tests/053.phpt] 
PASS Stream wrapper with header or file level passwords [tests/054.phpt] 
PASS Stream wrapper with volume find callback [tests/055.phpt] 
PASS RAR file stream stat [tests/056.phpt] 
PASS RAR file stream stat consistency with url stat [tests/057.phpt] 
PASS RAR file stream stat applied to directory consistency with url stat [tests/058.phpt] 
PASS url stat test [tests/059.phpt] 
PASS RAR directory stream basic test [tests/060.phpt] 
PASS RAR directory stream attempt on file [tests/061.phpt] 
PASS RAR directory stream stat [tests/062.phpt] 
PASS RAR directory stream stat consistency with url stat [tests/063.phpt] 
PASS RAR directory-aware traversal with directory streams [tests/064.phpt] 
PASS Directory streams compatibility with RecursiveDirectoryIterator [tests/065.phpt] 
PASS RarEntry::extract() (file level password) [tests/066.phpt] 
SKIP RarEntry::extract() process extended (Windows) [tests/067.phpt] reason: test is not working under run-tests
SKIP RarArchive direct instantiation does not crash (PHP 5.x) [tests/068.phpt] reason: for PHP 5.x
SKIP RarEntry direct instantiation does not crash (PHP 5.x) [tests/069.phpt] reason: for PHP 5.x
PASS URL stat PHP_STREAM_URL_STAT_QUIET does not leak memory [tests/070.phpt] 
PASS RarEntry::getPosition() test [tests/071.phpt] 
PASS rar_list handles files with non-unique entry names [tests/072.phpt] 
PASS RarEntry::getStream handles files with non-unique entry names [tests/073.phpt] 
PASS RarEntry::extract handles files with non-unique entry names [tests/074.phpt] 
PASS RarEntry::getStream NULL can be given to indicate there's no password [tests/075.phpt] 
PASS RarEntry::extract NULL can be given to indicate there's no password [tests/076.phpt] 
PASS RarArchive::open NULL can be given to indicate there's no password [tests/077.phpt] 
PASS Traversal of volume with only an archive continue from last volume [tests/078.phpt] 
PASS RarArchive count elements handler test [tests/079.phpt] 
PASS File stream EOF behavior [tests/080.phpt] 
PASS rar_list et al. give consistent results if called twice [tests/081.phpt] 
PASS RarArchive read_property handler basic test [tests/082.phpt] 
PASS RarArchive read_property handler non-int valid dimensions [tests/083.phpt] 
PASS RarArchive read_property handler invalid dimensions [tests/084.phpt] 
PASS RarArchive has_property handler is given a closed archive [tests/085.phpt] 
PASS RarArchive write_property gives a fatal error [tests/086.phpt] 
PASS RarArchive read_property gives a fatal error on a write context [tests/087.phpt] 
PASS RarArchive write_property gives a fatal error [tests/088.phpt] 
PASS RarArchive unset_property gives a fatal error [tests/089.phpt] 
PASS RarArchive has_property gives a fatal error [tests/090.phpt] 
PASS RarArchive::isBroken/rar_broken_is test [tests/091.phpt] 
PASS RarArchive::setAllowBroken has the desired effect [tests/092.phpt] 
PASS Traversal of RarArchive with foreach by reference gives error [tests/093.phpt] 
PASS rar_close is called twice [tests/094.phpt] 
PASS Wrapper cache exaustion test [tests/095.phpt] 
PASS Module info test [tests/096.phpt] 
PASS PECL bug #18449 (Extraction of uncompressed and encrypted files fails) [tests/097.phpt] 
PASS PECL bug #18449 (Extraction of uncompressed and encrypted files fails; stream variant) [tests/098.phpt] 
PASS Bug #59939: Streaming empty file from archive issues a warning [tests/099.phpt] 
PASS fopen modes 'r' and 'rb' are the only allowed [tests/100.phpt] 
PASS Supports version 5 RAR files [tests/101.phpt] 
PASS RarArchive direct instantiation does not crash (PHP 7) [tests/102.phpt] 
PASS RarEntry direct instantiation does not crash (PHP 7) [tests/103.phpt] 
PASS Clone of RarArchive is forbidden (PHP 7) [tests/104.phpt] 
SKIP Clone of RarArchive is forbidden (PHP 5.x) [tests/105.phpt] reason: for PHP 5.x
PASS Stat times don't depend on timezone (cf. 056.phpt) [tests/106.phpt] 
PASS Redirection functions [tests/107.phpt] 
PASS RarEntry::getPackedSize() [tests/108.phpt] 
PASS RarEntry::getHostOs() [tests/109.phpt] 
PASS RarEntry::getFileTime() [tests/110.phpt] 
PASS RarEntry::getVersion() [tests/111.phpt] 
PASS RarEntry::getMethod() [tests/112.phpt] 
PASS RarEntry::isEncrypted() [tests/113.phpt] 
PASS Bug 76592: solid files are partially extracted [tests/114.phpt] 
PASS getIterator() (PHP 8+) [tests/115.phpt] 
=====================================================================
TIME END 2022-09-15 08:26:10

=====================================================================
TEST RESULT SUMMARY
---------------------------------------------------------------------
Exts skipped    :    0
Exts tested     :   17
---------------------------------------------------------------------

Number of tests :  115               109
Tests skipped   :    6 (  5.2%) --------
Tests warned    :    0 (  0.0%) (  0.0%)
Tests failed    :    0 (  0.0%) (  0.0%)
Tests passed    :  109 ( 94.8%) (100.0%)
---------------------------------------------------------------------
Time taken      :    2 seconds
=====================================================================

Jan-E · 2022-12-15T09:05:38Z

@cataphract Can this PR be merged and a new release (4.3.0) be made including PHP 8.2 support? Thanks.

valy23 · 2023-04-25T11:56:22Z

@cataphract Please can you merge this PR and create new release? Thank you.

ernst77 · 2023-05-10T08:41:52Z

is this repo maintained?

Guite · 2023-07-17T11:41:23Z

push

Jan-E · 2023-07-17T13:30:27Z

push

Please

huqiye79 · 2023-07-31T01:20:27Z

Please

remicollet · 2023-09-04T09:48:29Z

Without new commit, using PHP 8.3.0RC1

TEST 2/115 [tests/002.phpt]
========DIFF========
--
     
     Warning: rar_open(): Failed to open %s: ERAR_EOPEN (file open error) in %s on line %d
     
144+ Warning: rar_list() expects parameter 1 to be RarArchive, false given in /dev/shm/BUILD/php83-php-pecl-rar-4.2.0/NTS/tests/002.php on line 13
144- Warning: rar_list() expects parameter 1 to be RarArchive, boo%s given in %s on line %d
     Done
========DONE========
FAIL rar_list() function [tests/002.phpt] 
TEST 3/115 [tests/003.phpt]
========DIFF========
--
     
     Warning: rar_open(): Failed to open %s: ERAR_EOPEN (file open error) in %s on line %d
     
070+ Warning: rar_entry_get() expects parameter 1 to be RarArchive, false given in /dev/shm/BUILD/php83-php-pecl-rar-4.2.0/NTS/tests/003.php on line 14
070- Warning: rar_entry_get() expects parameter 1 to be RarArchive, boo%s given in %s on line %d
     Done
========DONE========
FAIL rar_entry_get() function [tests/003.phpt] 
TEST 8/115 [tests/008.phpt]
========DIFF========
--
     
     Warning: rar_open(): Failed to open %s: ERAR_EOPEN (file open error) in %s on line %d
     
009+ Warning: rar_entry_get() expects parameter 1 to be RarArchive, false given in /dev/shm/BUILD/php83-php-pecl-rar-4.2.0/NTS/tests/008.php on line 14
009- Warning: rar_entry_get() expects parameter 1 to be RarArchive, boo%s given in %s on line %d
     
     Done
========DONE========
FAIL rar_entry_get() function [tests/008.phpt]

DnR-iData · 2023-12-08T15:31:51Z

Hello @cataphract,
Any update on this MR ?

Can you merge it in the next release plz.

Thanks

DR

DARKDAGGER5568 · 2024-12-05T20:35:13Z

i have this issue too!

PS E:\Code\subcenter> php -v      
PHP Warning:  RarArchive::__toString() implemented without string return type in Unknown on line 0
PHP Warning:  RarEntry::__toString() implemented without string return type in Unknown on line 0
PHP 8.2.26 (cli) (built: Nov 19 2024 18:15:27) (ZTS Visual C++ 2019 x64)
Copyright (c) The PHP Group
Zend Engine v4.2.26, Copyright (c) Zend Technologies

Can you please fix this problem so that this error doesn't appear?

remicollet · 2025-07-17T08:53:07Z

Additional patch for PHP 8.5.0alpha2

huqiye79 · 2025-12-05T05:58:23Z

Who can provide a download link for the php_rar.dll compatible with PHP 8.4 or PHP 8.5? Thank you!

Jan-E · 2025-12-05T06:45:59Z

Inside the zips on https://www.apachelounge.com/viewtopic.php?t=6359

huqiye79 · 2025-12-05T09:26:02Z

Inside the zips on https://www.apachelounge.com/viewtopic.php?t=6359

Many many thanks!

remicollet added 2 commits September 15, 2022 10:28

ignore more build artefacts

9be2291

fix __toString prototype for PHP 8.2

02331ca

remicollet mentioned this pull request Sep 15, 2022

PHP version 8.2 remicollet/remirepo#206

Closed

aimee-889 mentioned this pull request Jul 11, 2023

OPS-4871-update-nextcloud-to-26 hpi-schul-cloud/schulcloud-nextcloud#30

Merged

1 task

relax tests expectations for 8.3

eefdef2

remicollet changed the title ~~Issue php82~~ PHP 8.2 and 8.3 compatibility Sep 4, 2023

remicollet mentioned this pull request Sep 4, 2023

PHP Version 8.3 remicollet/remirepo#237

Closed

crazywhalecc mentioned this pull request Nov 9, 2023

Add rar support crazywhalecc/static-php-cli#260

Merged

8 tasks

tsukasa-mixer mentioned this pull request Feb 28, 2025

Warning on php 8.2+: RarArchive::__toString() \ RarEntry::__toString() implemented without string return type #20

Closed

use zend_ce_exception instead of zend_exception_get_default() for 8.5

048aa2b

remicollet mentioned this pull request Jul 17, 2025

PHP version 8.5 remicollet/remirepo#307

Closed

Comments

Conversation

remicollet commented Sep 15, 2022

Uh oh!

Jan-E commented Dec 15, 2022

Uh oh!

valy23 commented Apr 25, 2023

Uh oh!

ernst77 commented May 10, 2023

Uh oh!

Guite commented Jul 17, 2023

Uh oh!

Jan-E commented Jul 17, 2023

Uh oh!

huqiye79 commented Jul 31, 2023

Uh oh!

remicollet commented Sep 4, 2023

Uh oh!

DnR-iData commented Dec 8, 2023

Uh oh!

DARKDAGGER5568 commented Dec 5, 2024

Uh oh!

remicollet commented Jul 17, 2025

Uh oh!

huqiye79 commented Dec 5, 2025

Uh oh!

Jan-E commented Dec 5, 2025

Uh oh!

huqiye79 commented Dec 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants