Skip to content

Allow Editor Theme Change with Windows Theme (Dark/Light)#555

Open
0x4A4D00 wants to merge 2 commits into
castle-engine:masterfrom
0x4A4D00:windows-dark
Open

Allow Editor Theme Change with Windows Theme (Dark/Light)#555
0x4A4D00 wants to merge 2 commits into
castle-engine:masterfrom
0x4A4D00:windows-dark

Conversation

@0x4A4D00

Copy link
Copy Markdown

Using this Package We can use Dark/Light Theme on Windows.

Metadarkstyle Package needs to be installed on Lazarus.
Maybe It's better to change the color of the editor buttons' images a little.

_gameviewplay castle-user-interface  test-3 _ Castle Game Engine 12_14_2023 2_24_44 PM

@michaliskambi

michaliskambi commented Dec 14, 2023

Copy link
Copy Markdown
Member

Interesting, thank you! The modification to CGE editor is very small, so it may make sense. (In the past I was reluctant to add to CGE editor some "heavy" code modifications, that would only give us dark mode, and were usually not-cross-platform. This is also not cross-platform, but the modification is admittedly very small, not a problem to maintain.)

Note that we'd have to distribute https://github.com/zamtmn/metadarkstyle along with CGE to make it available out-of-the-box. Experience shows that each time we add a new package as dependency, it has to be in packages/ so that compilation works "out of the box" for everyone.

I'll test and think. Thank you!

@0x4A4D00

Copy link
Copy Markdown
Author

I'm glad it was useful!

As far as I know, programs like CGE and Lazarus, on various operating systems such as Linux distributions, macOS, and various BSDs(I worked with CGE on OpenBSD), synchronize their themes with the operating system and desktop environment. This issue is only present within Windows.

Additionally, using this package, you might be able to use Qt instead of WinForms with a dark theme on Windows and also other platforms.

Anyway, do I need to make any changes or add something to this pull request now?

@michaliskambi

Copy link
Copy Markdown
Member

Anyway, do I need to make any changes or add something to this pull request now?

No, it's good. I need to test it and decide, it's on me :)

How to include https://github.com/zamtmn/metadarkstyle in CGE repo -- I'll also see the best way to do this. Then the CI (GitHub Actions / Jenkins) will pass.

@michaliskambi

Copy link
Copy Markdown
Member

Thanks for updating PR to latest CGE!

I really have a TODO to finish it, test and include the https://github.com/zamtmn/metadarkstyle into CGE. I did already make a decision to do this, e.g. add "dark mode" to CGE editor on Windows this way. I refer to this PR from https://castle-engine.io/roadmap#dark_mode too. So, it will happen, have patience with me :)

@michaliskambi

Copy link
Copy Markdown
Member

Just bumping this to tell that, while it takes us ages, it's still really a TODO :) That is, figure out how/if we want to ship MetaDarkStyle in CGE, and then test and apply this PR.

Since:

-> it's all a great confirmation that MetaDarkStyle is actively maintained and recommended by Lazarus themselves. Which makes it perfect for CGE editor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants