fix: restyle onboarding emoji rows as subtle background texture#232
Merged
a1denvalu3 merged 8 commits intomainfrom Mar 24, 2026
Merged
fix: restyle onboarding emoji rows as subtle background texture#232a1denvalu3 merged 8 commits intomainfrom
a1denvalu3 merged 8 commits intomainfrom
Conversation
Shrink tiles (48dp), add ghost-opacity backgrounds, expand to 5 rows with aggressive bottom fade, and slow speeds with varied pacing so the section feels like a faint dissolving texture rather than a UI component. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Remove rounded-rect gradient backgrounds so emojis float bare on the navy background — reads as texture, not a grid component. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Collaborator
Author
|
@a1denvalu3 @callebtc ready for feedback and review. |
- Fix postDelayed lifecycle leaks by migrating OnboardingWelcomeAnimator to use Coroutines (suspendCancellableCoroutine) - Extract hardcoded colors (navy, white) to use resource values - Add pause() and resume() support to correctly halt infinite animators when activity is in the background - Pass Activity instead of Context to avoid casting for Window manipulations
- Fix IllegalStateException from attaching multiple invokeOnCancellation handlers to a single suspendCancellableCoroutine by batching animator cancellations. - Fix ConcurrentModificationException in stop() by operating on a copy of the activeAnimators list before clearing it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Demo
onboarding-new-emojis.mp4
Summary
Test plan
🤖 Generated with Claude Code