Fix/transaction details by swedishfrenchpress · Pull Request #225 · cashubtc/Numo

swedishfrenchpress · 2026-03-15T15:14:02Z

Transaction Details Overhaul

Video Walkthrough

https://drive.proton.me/urls/54ZY89XJ1C#VMHxHhpoSNpT

Summary

Redesigned the Transaction Details screen with improved layout, typography hierarchy, and support for all transaction types (send, receive, withdraw)
Added total balance to the top of activity screen
Added withdraw transactions to the Activity list and Transaction Details, including "Sent To" destination display
Implemented "Label Transaction" feature allowing users to tag transactions with custom labels, persisted across sessions
Added CSV export functionality to activity

Changes

Transaction Details Screen

Rebuilt activity_transaction_detail.xml layout with cleaner structure and improved typography hierarchy (primary amount large/bold, secondary amount medium, date small)
Added overflow menu with "Label Transaction" and "Print Receipt" options
Fixed invoice/Cashu request fields displaying in smaller font than other detail values
Fixed mint field showing raw URL instead of display name
Styled the dropdown/popup menu to match the app's design system
Added dark mode support for transaction detail theming

Withdraw Transaction Support

Withdraw transactions now appear in the Activity history list with proper send/receive directional icons
Transaction Details shows "Sent To" row with the withdraw destination address
"Print Receipt" is hidden for withdraw transactions

Label Transaction Feature

Users can label any transaction via the overflow menu dialog
Labels persist in SharedPreferences alongside existing payment history data
Labels display on both the Transaction Details screen and as a subtitle in the Activity list
Existing update methods preserve labels when modifying transaction state
Translations added for EN, PT, and ES

Activity Screen

Updated PaymentsHistoryAdapter with multi-view-type support (month headers + transaction items)
Improved transaction row layout with directional arrow icons and status badges
Added total balance to top of activity section

QA

Verify transaction details display correctly for all types: receive (Lightning, Cashu), send, and withdraw
Verify fiat amounts and exchange rates display using transaction-time price
Verify mint names (not raw URLs) display across all transaction types
Test labeling a transaction, closing and reopening — label should persist
Test removing a label (clear text and save)
Verify labels appear as subtitles in the Activity list
Test CSV export then re-import — SATS, VAT, Inventory fields should roundtrip correctly
Verify dark mode renders correctly on Transaction Details
Verify PT and ES translations for label-related strings

swedishfrenchpress · 2026-03-15T22:58:30Z

@a1denvalu3 ready for review. i completed all the QA test in the PR description and updated the PR description to reflect the changes.

: /Users/erik/.config/opencode/opencode.json

a1denvalu3 · 2026-03-16T11:46:52Z

app/src/main/java/com/electricdreams/numo/feature/history/PaymentsHistoryActivity.kt

+                PaymentHistoryEntry(
+                    id = w.id,
+                    token = w.token ?: "",
+                    amount = -w.amountSats, // Negative = outgoing
+                    date = Date(w.timestamp),
+                    rawUnit = "sat",
+                    rawEntryUnit = "sat",
+                    enteredAmount = w.amountSats,
+                    bitcoinPrice = null,
+                    mintUrl = w.mintUrl,
+                    paymentRequest = w.destination.ifBlank { w.lightningAddress },
+                    rawStatus = when (w.status) {
+                        WithdrawHistoryEntry.STATUS_COMPLETED -> PaymentHistoryEntry.STATUS_COMPLETED
+                        WithdrawHistoryEntry.STATUS_PENDING -> PaymentHistoryEntry.STATUS_PENDING
+                        else -> PaymentHistoryEntry.STATUS_COMPLETED
+                    },
+                    paymentType = PaymentHistoryEntry.TYPE_LIGHTNING,
+                )


We're converting a withdrawal entry to a PaymentHistoryEntry very loosely. The answer would be to create a History entry that is a union between a payment history entry and a withdrawal history entry.

i ran your feedback through opus and pushed a fix in this commit: f3a09c8

i also tested the export functionality after building a version with this commit. it works. the csv export looks a bit cleaner: numo_activity_export_2026-03-16 (1).csv

app/src/main/java/com/electricdreams/numo/feature/history/PaymentsHistoryActivity.kt

a1denvalu3 · 2026-03-16T11:47:55Z

Conflicts with the main branch

swedishfrenchpress · 2026-03-16T14:46:06Z

@a1denvalu3 i found a glitch while testing. labels adding to withdrawals are not being saved. i'll work on a fix for this asap.

swedishfrenchpress · 2026-03-17T10:29:00Z

@a1denvalu3 i fixed the withdrawal label issue (c92e9a9) and pushed a small color update to the delete transaction action (6816279). I think this is ready for review.

I also tested the csv export. the labels are all showing for the transactions that have labels.

The opencode.json config file was accidentally added to the repo. This is a local tool configuration and should not be tracked. Co-Authored-By: Claude Opus 4.6 <[email protected]>

…tails.

…istoryEntry interface Withdrawals were being shoehorned into PaymentHistoryEntry with fake/empty fields. Now both types implement a shared HistoryEntry interface and are used directly in the history list, CSV export, and transaction detail flows.

…ure of action.

github-project-automation bot added this to Numo Mar 15, 2026

github-project-automation bot moved this to Backlog in Numo Mar 15, 2026

swedishfrenchpress marked this pull request as ready for review March 15, 2026 22:58

a1denvalu3 reviewed Mar 16, 2026

View reviewed changes

: /Users/erik/.config/opencode/opencode.json Outdated Show resolved Hide resolved

a1denvalu3 reviewed Mar 16, 2026

View reviewed changes

swedishfrenchpress and others added 19 commits March 18, 2026 13:39

fix: transaction details UI updates.

ce802f7

chore: remove accidentally committed opencode config

a655503

The opencode.json config file was accidentally added to the repo. This is a local tool configuration and should not be tracked. Co-Authored-By: Claude Opus 4.6 <[email protected]>

fix: removed open-code config.

37b6e4c

fix: transaction settings drop down menu style.

ace8d6c

feat: added withdraw to transaction details list.

9e637a0

fix: withdraw address added to withdraw transaction details.

81017f1

fix:invoice/cashu request font size. mint name fix for transaction de…

c4e3b3d

…tails.

fix: payment amounts.

9c07d92

feat: transaction label functionality.

d16e2f5

feat: activity csv export functionality.

33808fe

fix: remove opencode.json config.

c16d703

fix: persistent label adding for withdrawals on activity screen.

1a4752d

fix: delete transaction color updated to red to match destructive nat…

abbc745

…ure of action.

fix: resolve rebase issues with history delete and labels

d152b88

fix: change 'Print Receipt' to 'Receipt' in all languages

3801636

fix: prevent status badge clipping in history items

43f18fa

fix: total balance does not update correctly on load

cb01a27

feat: show loading hint for balance on history screen

4c50f96

a1denvalu3 force-pushed the fix/transaction-details branch from 6816279 to 4c50f96 Compare March 18, 2026 13:54

fix: resolve double negation formatting on withdrawals in history list

7351487

a1denvalu3 merged commit 44677c3 into main Mar 18, 2026
3 checks passed

github-project-automation bot moved this from Backlog to Done in Numo Mar 18, 2026

a1denvalu3 deleted the fix/transaction-details branch March 18, 2026 21:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/transaction details#225

Fix/transaction details#225
a1denvalu3 merged 20 commits intomainfrom
fix/transaction-details

swedishfrenchpress commented Mar 15, 2026 •

edited

Loading

Uh oh!

swedishfrenchpress commented Mar 15, 2026

Uh oh!

Uh oh!

a1denvalu3 Mar 16, 2026

Uh oh!

swedishfrenchpress Mar 16, 2026

Uh oh!

Uh oh!

a1denvalu3 commented Mar 16, 2026

Uh oh!

swedishfrenchpress commented Mar 16, 2026 •

edited

Loading

Uh oh!

swedishfrenchpress commented Mar 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

swedishfrenchpress commented Mar 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Transaction Details Overhaul

Video Walkthrough

Summary

Changes

QA

Uh oh!

swedishfrenchpress commented Mar 15, 2026

Uh oh!

Uh oh!

a1denvalu3 Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

swedishfrenchpress Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

a1denvalu3 commented Mar 16, 2026

Uh oh!

swedishfrenchpress commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

swedishfrenchpress commented Mar 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

swedishfrenchpress commented Mar 15, 2026 •

edited

Loading

swedishfrenchpress commented Mar 16, 2026 •

edited

Loading