Merged
Conversation
This uses the melt with proofs and prevents a swap before the melt In the case of the unknown mint we create a temp wallet and do not receive those proofs to the wallet. Instead we melt directly with them. We do not want a swap before the melt to prevent a partial operation. If we swap but the melt fails we have spent the senders tokens but we have not received them to our wallet as we do not trust there mint
a1denvalu3
approved these changes
Mar 9, 2026
Collaborator
|
Tested ACK |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses the melt with proofs and prevents a swap before the melt In the case of the unknown mint we create a temp wallet and do not receive those proofs to the wallet. Instead we melt directly with them.
We do not want a swap before the melt to prevent a partial operation. If we swap but the melt fails we have spent the senders tokens but we have not received them to our wallet as we do not trust there mint