Fix e2e/smoke tests#8
Merged
caseyduquettesc merged 1 commit intocaseyduquettesc:mainfrom Aug 17, 2023
Merged
Conversation
caseyduquettesc
approved these changes
Aug 17, 2023
Owner
caseyduquettesc
left a comment
caseyduquettesc
left a comment
There was a problem hiding this comment.
Thank you so much! I haven't had time to look into the failure myself
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest release failed to publish to BCR due to smoke test failing: bazelbuild/bazel-central-registry#817
I was also able to reproduce the error locally; I was unable to reproduce in GitHub Actions, even though everything seems to be correctly configured.
The failure seems to be due to the
is_defaultparameter, which I believe was only introduced inrules_pythonon 0.23.0 (on bazel-contrib/rules_python#1230). Hence, bump the version ofrules_pythonto a recent version and update the smoke test based on current examples.