Avoid passing __init__.py files to pytest to mitigate bug#3
Merged
caseyduquettesc merged 1 commit intocaseyduquettesc:mainfrom Jun 16, 2023
Merged
Avoid passing __init__.py files to pytest to mitigate bug#3caseyduquettesc merged 1 commit intocaseyduquettesc:mainfrom
caseyduquettesc merged 1 commit intocaseyduquettesc:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We sometimes use
py_pytest_testpassingsrcs = glob(["*.py"])to run every python test in the folder in a single pytest run. This triggers a pytest bug that causes all tests to be run twice due to the inclusion of__init__.py, which is expanded to include the entire directory: pytest-dev/pytest#9313To avoid this, filter any
__init__.pyfile when computing the arguments passed to pytest.I decided to do the filtering in Python rather than in Starlark since we would need to expand labels (ie. resolve
$(location :%s)) to determine basename, which I believe is not possible to do on a bazel macro.