Allow interchangable recipe redefinitions #2437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Yeah, seems sensible enough |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2436.
@neunenak Does this seem reasonable to you? See the original issue, but basically, if you have the same recipe imported in multiple places in the same module, you'll get an error. This seems safe to allow, since they're exactly the same recipe. Allowing it is kind of like automatically wrapping recipes in C-style include guards.
This is a bit hacky, since it only works for recipes. The less hacky way to do it would be to just ignore an import if it's a file that's already been imported into this module, which would work for everything.