Simplify Subcommand::run
#2336
Merged
Simplify Subcommand::run
#2336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neunenak
force-pushed
the
run-subcommand
branch
from
2e1ab3e to
9fc7538
Compare
Owner
|
Won't this lead to double compiling the first justfile, since it's already compiled before we call run? |
Contributor
Author
Whoops, yeah. Added a commit that fixes this. |
Owner
|
Nice, this is a great simplification! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Subcommand::runfunction is a bit messy because it needs to handle the case where fallback is enabled and a missing recipe triggers searching for a new justfile further up the directory tree. This commit attempts to simplify the loop withinSubcommand::runand make the logic generally easier to understand.