-
Notifications
You must be signed in to change notification settings - Fork 33
feat: add dockerfile #533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add dockerfile #533
Conversation
Signed-off-by: rare-magma <[email protected]>
casey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Can we avoid using docker.io/lukemathwalker/cargo-chef:latest-rust-latest, at least for the first version? I'd like to make the docker file as minimal as possible initially, and then make modifications/improvements in follow-up PRs.
Signed-off-by: rare-magma <[email protected]>
|
@casey I've simplified the dockerfile to use the official docker library rust image as the build stage. The drawback with this approach is that any change in the repository invalidates the docker cache and results in a full rebuild. In the end it shouldn't matter if the image is only built once per release. |
Signed-off-by: rare-magma <[email protected]>
casey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments. I want to keep things as vanilla as possible, and use official, standard images where possible.
Signed-off-by: rare-magma <[email protected]>
Signed-off-by: rare-magma <[email protected]>
|
Gotcha, in that case distroless sounds good. I probably won't wind up publishing the docker image myself, I avoid managing package repo packages myself because it's extra work to remember then releasing, so for now let's remove the reference to |
Signed-off-by: rare-magma <[email protected]>
@casey I've removed the reference to ghcr in e4cf429 In case you'd like to publish it automatically in the future it can be done easily with a github action as described in https://docs.github.com/en/actions/publishing-packages/publishing-docker-images#publishing-images-to-github-packages |
|
Looks good to me! I changed |
|
The build failure is unrelated to this PR. I'll fix it in another PR and then merge this. |
|
Blocked on #537. |
|
Merged, thanks for the PR! |
Containerizing intermodal makes it easier to use without installing it.
The docker image can be hosted on ghcr.io and its build automated via github action:
https://docs.github.com/en/actions/publishing-packages/publishing-docker-images
The container can then be used like this:
docker run --rm --init --interactive --tty --volume "$(pwd)":/mnt ghcr.io/casey/intermodal torrent show /mnt/example.torrent