Merged
Conversation
Contributor
vangie
commented
Mar 8, 2023
vangie
commented
- Compile arm64 binaries
- Migrating from dep to go module
- upgrade golang.org/x/crypto to v0.7.0 for go1.20.2
This was referenced Mar 8, 2023
Closed
vangie
force-pushed
the
vangie/support-arm64
branch
from
3737830 to
014cc1c
Compare
joaopapereira
requested changes
Apr 4, 2023
Member
joaopapereira
left a comment
joaopapereira
left a comment
There was a problem hiding this comment.
The change looks good. For all the other tools on the Carvel suite we are trying to keep the vendor folder present so that when you download the git repo you will get all the needed dependencies.
Another thing that I noticed was that when I run build locally using go 1.20 I got a diff on
diff --git a/pkg/kwt/cmd/core/strings_single_line_value.go b/pkg/kwt/cmd/core/strings_single_line_value.go
index c3af264..ca6ee35 100644
--- a/pkg/kwt/cmd/core/strings_single_line_value.go
+++ b/pkg/kwt/cmd/core/strings_single_line_value.go
@@ -10,7 +10,9 @@ type ValueStringsSingleLine struct {
S []string
}
-func NewValueStringsSingleLine(s []string) ValueStringsSingleLine { return ValueStringsSingleLine{S: s} }
+func NewValueStringsSingleLine(s []string) ValueStringsSingleLine {
+ return ValueStringsSingleLine{S: s}
+}
func (t ValueStringsSingleLine) String() string { return strings.Join(t.S, ", ") }
func (t ValueStringsSingleLine) Value() uitable.Value { return t }
diff --git a/pkg/kwt/net/forwarder/linux_orig_dst_resolver_linux.go b/pkg/kwt/net/forwarder/linux_orig_dst_resolver_linux.go
index ac5109d..d695be8 100644
--- a/pkg/kwt/net/forwarder/linux_orig_dst_resolver_linux.go
+++ b/pkg/kwt/net/forwarder/linux_orig_dst_resolver_linux.go
@@ -1,3 +1,4 @@
+//go:build linux
// +build linux
package forwarder
diff --git a/pkg/kwt/net/forwarder/linux_orig_dst_resolver_other.go b/pkg/kwt/net/forwarder/linux_orig_dst_resolver_other.go
index d41a49a..bd1e3c0 100644
--- a/pkg/kwt/net/forwarder/linux_orig_dst_resolver_other.go
+++ b/pkg/kwt/net/forwarder/linux_orig_dst_resolver_other.go
@@ -1,3 +1,4 @@
+//go:build !linux
// +build !linux
package forwarder
Do you mind doing that change?
Contributor
Author
@joaopapereira What command can I run to reproduce this diff problem?I understand that I have not changed these files, your local prettifer or lint plugin caused? |
vangie
force-pushed
the
vangie/support-arm64
branch
from
014cc1c to
9dcbeb5
Compare
1. Compile arm64 binaries 2. Migrating from dep to go module 3. Upgrade golang.org/x/crypto to v0.7.0 for go1.20.2 Signed-off-by: Vangie Du <[email protected]>
vangie
force-pushed
the
vangie/support-arm64
branch
from
9dcbeb5 to
af3cb7c
Compare
Member
|
@vangie sorry for the late reply but I was out. git fetch origin pull/35/head:arm-pr
git checkout arm-pr
./hack/build.shand this is the output I get: |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.