Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
This is PR 2 of the UiParameter split stack, based on PR 1.
This PR adds Scala-side infrastructure for injecting UI parameter values into Python UDF code, but does not activate it in execution yet.
It includes:
PythonUdfUiParameterInjector.Execution remains unchanged in this PR: Python UDF descriptors still call
OpExecWithCode(code, "python").sequenceDiagram autonumber participant Desc as Scala UDF Descriptor participant Params as uiParameters Metadata participant Injector as PythonUdfUiParameterInjector participant Tests as Injector Specs participant Exec as Existing Execution Path Desc->>Params: Holds inert uiParameters Tests->>Injector: Validate injection behavior Injector->>Injector: Validate names, types, reserved hook Injector->>Injector: Generate hook code when called Desc->>Exec: Still executes original code Note over Desc,Exec: Injector exists but is not wired into runtime yet