Skip to content

fix(deploy): allow to set iam role tags when created#869

Merged
calavera merged 2 commits intocargo-lambda:mainfrom
floydspace:feat/set-iam-role-tags
Jul 15, 2025
Merged

fix(deploy): allow to set iam role tags when created#869
calavera merged 2 commits intocargo-lambda:mainfrom
floydspace:feat/set-iam-role-tags

Conversation

@floydspace
Copy link
Copy Markdown
Contributor

@floydspace floydspace commented Jul 14, 2025 •
edited
Loading

to have better overview in the AWS Resource Explorer what resources was created by the cargo-lambda, I'm adding tags for the iam role created during deploy

here is how it works:

  1. deploy with tags
❯ cargo lambda deploy --tags cargo:service-name=s3-to-sns
✅ function deployed successfully 🎉
🛠️  binary last compiled 2 days ago
🔍 arn: arn:aws:lambda:eu-central-1:<REDACTED>:function:s3-to-sns
🎭 version: 3
  1. the role tags
image

@floydspace floydspace marked this pull request as ready for review July 15, 2025 09:55
calavera
calavera approved these changes Jul 15, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@calavera calavera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks a lot for the contribution!

@floydspace
Copy link
Copy Markdown
Contributor Author

floydspace commented Jul 15, 2025

I see clippy produces many changes unrelated to the PR changes, shoudl I go ahead commiting them?

@calavera
Copy link
Copy Markdown
Collaborator

calavera commented Jul 15, 2025

I see clippy produces many changes unrelated to the PR changes, shoudl I go ahead commiting them?

I'm about to push a PR with all those clippy changes. I think after they're in main, this PR should pass cleanly with a merge.

@calavera
Copy link
Copy Markdown
Collaborator

calavera commented Jul 15, 2025

I'll release a new version with this feature this week.

@calavera calavera merged commit b941070 into cargo-lambda:main Jul 15, 2025
7 checks passed
@floydspace
Copy link
Copy Markdown
Contributor Author

floydspace commented Jul 15, 2025

thanks, @calavera
Versioning and publishing is manual?

@floydspace floydspace deleted the feat/set-iam-role-tags branch July 15, 2025 19:52
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 15, 2025

This pull request has been automatically locked. Create a new discussion if you'd like to continue the conversation. https://github.com/cargo-lambda/cargo-lambda/discussions/new?category=general

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@calavera calavera calavera approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@floydspace @calavera