Thanks for opening this issue!

It looks like Rust file:rename can fail in some Linux kernels, according to a similar issues in rustup: rust-lang/rustup#1239

The solution seems to be to capture the error and do a Copy+Delete in those cases.

Aah, interesting. I'd expect that having /tmp on a different device would be not uncommon on *nix systems.

Rustup's fix involved them implementing some util functions themselves to fall back to copy+delete on a failed move/rename, but this seems like the kind of thing that should be in an existing library though rather than copy/pasting code from there.

fs_extra's move_dir seems like a candidate but I'm not sure if fs_extra is still maintained.

Ha, just seen your PR after writing the above, thanks for the quick turnaround!

@sdd I'll probably release a new version in the next couple of days. Meanwhile you can install it by cloning the repo:

git clone https://github.com/cargo-lambda/cargo-lambda
cd cargo-lambda
cargo install --force --path crates/cargo-lambda-cli

Will give it a go tomorrow, thanks!

Hi @calavera - unfortunately that change didn't fix the problem. If I change rename to the below then it works - but it requires the unstable #![feature(io_error_more)]:

pub fn rename<P, Q>(from: P, to: Q) -> io::Result<()>
where
    P: AsRef<Path>,
    Q: AsRef<Path>,
{
    match fs::rename(&from, &to) {
        Ok(ok) => Ok(ok),
        Err(e) => match e.kind() {
            io::ErrorKind::CrossesDevices => {
                match copy_and_delete(from, to) {
                    Ok(()) => Ok(()),
                    Err(_) => Err(e),
                }
            },
            _ => Err(e),
        },
    }
}

Sounds like ErrorKind::Other does not get returned anymore: rust-lang/rust#85746

I think we can check against the error code directly for now until this is io_error_more is stabilized: rust-lang/rust#86442 (comment)

Aah, this works, without needing io_error_more:

pub fn rename<P, Q>(from: P, to: Q) -> io::Result<()>
where
    P: AsRef<Path>,
    Q: AsRef<Path>,
{
    match fs::rename(&from, &to) {
        Ok(ok) => Ok(ok),
        Err(e) if Some(libc::EXDEV) == e.raw_os_error() => {
            match copy_and_delete(from, to) {
                Ok(()) => Ok(()),
                Err(_) => Err(e),
            }
        },
        Err(e) => Err(e),
    }
}